c2c: bsqrt, acct_params_get (#3404)

also an e2e inner appl test

Author: jannotti

THANKS.md

@@ -5,6 +5,7 @@ A big thank you to everyone who has contributed to the `go-algorand` codebase.
 
 ### External Contributors
 - aybehrouz
+- fionnachan
 - jeapostrophe
 - jecassis
 - jsign

cmd/opdoc/opdoc.go

@@ -286,28 +286,6 @@ type LanguageSpec struct {
 	Ops             []OpRecord
 }
 
-func argEnum(name string) []string {
-	if name == "txn" || name == "gtxn" || name == "gtxns" {
-		return logic.TxnFieldNames
-	}
-	if name == "global" {
-		return logic.GlobalFieldNames
-	}
-	if name == "txna" || name == "gtxna" || name == "gtxnsa" || name == "txnas" || name == "gtxnas" || name == "gtxnsas" {
-		return logic.TxnaFieldNames()
-	}
-	if name == "asset_holding_get" {
-		return logic.AssetHoldingFieldNames
-	}
-	if name == "asset_params_get" {
-		return logic.AssetParamsFieldNames
-	}
-	if name == "app_params_get" {
-		return logic.AppParamsFieldNames
-	}
-	return nil
-}
-
 func typeString(types []logic.StackType) string {
 	out := make([]byte, len(types))
 	for i, t := range types {
@@ -330,27 +308,32 @@ func typeString(types []logic.StackType) string {
 	return string(out)
 }
 
-func argEnumTypes(name string) string {
-	if name == "txn" || name == "gtxn" || name == "gtxns" || name == "itxn" || name == "gitxn" || name == "itxn_field" {
-		return typeString(logic.TxnFieldTypes)
-	}
-	if name == "global" {
-		return typeString(logic.GlobalFieldTypes)
-	}
-	if name == "txna" || name == "gtxna" || name == "gtxnsa" || name == "txnas" || name == "gtxnas" || name == "gtxnsas" || name == "itxna" || name == "gitxna" {
-		return typeString(logic.TxnaFieldTypes())
-	}
-	if name == "asset_holding_get" {
-		return typeString(logic.AssetHoldingFieldTypes)
-	}
-	if name == "asset_params_get" {
-		return typeString(logic.AssetParamsFieldTypes)
-	}
-	if name == "app_params_get" {
-		return typeString(logic.AppParamsFieldTypes)
+func fieldsAndTypes(names []string, specs speccer) ([]string, string) {
+	types := make([]logic.StackType, len(names))
+	for i, name := range names {
+		types[i] = specs.SpecByName(name).Type()
 	}
+	return names, typeString(types)
+}
 
-	return ""
+func argEnums(name string) (names []string, types string) {
+	switch name {
+	case "txn", "gtxn", "gtxns", "itxn", "gitxn", "itxn_field":
+		return fieldsAndTypes(logic.TxnFieldNames, logic.TxnFieldSpecByName)
+	case "global":
+		return
+	case "txna", "gtxna", "gtxnsa", "txnas", "gtxnas", "gtxnsas", "itxna", "gitxna":
+		// Map is the whole txn field spec map.  That's fine, we only lookup the given names.
+		return fieldsAndTypes(logic.TxnaFieldNames(), logic.TxnFieldSpecByName)
+	case "asset_holding_get":
+		return fieldsAndTypes(logic.AssetHoldingFieldNames, logic.AssetHoldingFieldSpecByName)
+	case "asset_params_get":
+		return fieldsAndTypes(logic.AssetParamsFieldNames, logic.AssetParamsFieldSpecByName)
+	case "app_params_get":
+		return fieldsAndTypes(logic.AppParamsFieldNames, logic.AppParamsFieldSpecByName)
+	default:
+		return nil, ""
+	}
 }
 
 func buildLanguageSpec(opGroups map[string][]string) *LanguageSpec {
@@ -363,8 +346,7 @@ func buildLanguageSpec(opGroups map[string][]string) *LanguageSpec {
 		records[i].Returns = typeString(spec.Returns)
 		records[i].Cost = spec.Details.Cost
 		records[i].Size = spec.Details.Size
-		records[i].ArgEnum = argEnum(spec.Name)
-		records[i].ArgEnumTypes = argEnumTypes(spec.Name)
+		records[i].ArgEnum, records[i].ArgEnumTypes = argEnums(spec.Name)
 		records[i].Doc = logic.OpDoc(spec.Name)
 		records[i].DocExtra = logic.OpDocExtra(spec.Name)
 		records[i].ImmediateNote = logic.OpImmediateNote(spec.Name)
@@ -416,6 +398,10 @@ func main() {
 	fieldSpecsMarkdown(appparams, logic.AppParamsFieldNames, logic.AppParamsFieldSpecByName)
 	appparams.Close()
 
+	acctparams, _ := os.Create("acct_params_fields.md")
+	fieldSpecsMarkdown(acctparams, logic.AcctParamsFieldNames, logic.AcctParamsFieldSpecByName)
+	acctparams.Close()
+
 	langspecjs, _ := os.Create("langspec.json")
 	enc := json.NewEncoder(langspecjs)
 	enc.Encode(buildLanguageSpec(opGroups))

data/transactions/logic/README.md

@@ -234,6 +234,12 @@ App fields used in the `app_params_get` opcode.
 
 @@ app_params_fields.md @@
 
+**Account Fields**
+
+Account fields used in the `acct_params_get` opcode.
+
+@@ acct_params_fields.md @@
+
 ### Flow Control
 
 @@ Flow_Control.md @@
@@ -264,11 +270,11 @@ with the next instruction with, for example, `balance` and
 
 In v5, only a few of the Header fields may be set: `Type`/`TypeEnum`,
 `Sender`, and `Fee`. In v6, Header fields `Note` and `RekeyTo` may
-also be set.  For the specific fields of each transaction types, any
-field may be set (except `RekeyTo` in v5).  This allows, for example,
-clawback transactions, asset opt-ins, and asset creates in addition to
-the more common uses of `axfer` and `acfg`.  All fields default to the
-zero value, except those described under `itxn_begin`.
+also be set.  For the specific (non-header) fields of each transaction
+type, any field may be set.  This allows, for example, clawback
+transactions, asset opt-ins, and asset creates in addition to the more
+common uses of `axfer` and `acfg`.  All fields default to the zero
+value, except those described under `itxn_begin`.
 
 Fields may be set multiple times, but may not be read. The most recent
 setting is used when `itxn_submit` executes. For this purpose `Type`