Commit 5ef60a7
authored
Goal: Add check for signer passed in the case of logic sig rekeyed account (#3773)
## Summary
When trying to sign a transaction file with goal, if the sender is a normal address but the signer is a logic program, the call fails with an error message like:
`send.txn: txn[0] error LogicNot signed and not a Logic-only account`
The error message comes from https://github.com/algorand/go-algorand/blob/33b87c432065d3be0ce1fdad682604f416676133/data/transactions/verify/txn.go#L314
It notes that a valid case is when Auth is set to the hash of the program but we aren't setting the auth on the transaction even if the -S flag is passed
## Test Plan
Made a txn where sender is a regular account and signed it with
```sh
goal clerk sign -i tmp.txn -o tmp.txn -S BJATCHES5YJZJ7JITYMVLSSIQAVAWBQRVGPQUDT5AZ2QSLDSXWWM46THOY -p tmp.teal
```
I borked the git history on the last one #3459 so just nuked it and starting over here.
Left it at @tsachiherman wanting better tests for this #3459 (comment)1 parent 0e79364 commit 5ef60a7
1 file changed
+9
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
724 | 724 | | |
725 | 725 | | |
726 | 726 | | |
727 | | - | |
| 727 | + | |
728 | 728 | | |
729 | 729 | | |
730 | 730 | | |
| |||
743 | 743 | | |
744 | 744 | | |
745 | 745 | | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
746 | 751 | | |
747 | 752 | | |
748 | 753 | | |
| |||
790 | 795 | | |
791 | 796 | | |
792 | 797 | | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
793 | 801 | | |
794 | 802 | | |
795 | 803 | | |
| |||
0 commit comments