update per peer review

Author: tsachiherman

data/account/participation_test.go

@@ -462,9 +462,8 @@ func TestKeyregValidityOverLimit(t *testing.T) {
 	partitiontest.PartitionTest(t)
 	a := require.New(t)
 
-	// TODO: change to ConsensusCurrentVersion when updated
-	maxValidPeriod := config.Consensus[protocol.ConsensusFuture].MaxKeyregValidPeriod
-	dilution := config.Consensus[protocol.ConsensusFuture].DefaultKeyDilution
+	maxValidPeriod := config.Consensus[protocol.ConsensusCurrentVersion].MaxKeyregValidPeriod
+	dilution := config.Consensus[protocol.ConsensusCurrentVersion].DefaultKeyDilution
 
 	var address basics.Address
 	crypto.RandBytes(address[:])

ledger/accountdb_test.go

@@ -290,7 +290,7 @@ func TestAccountDBRound(t *testing.T) {
 }
 
 func TestAccountStorageWithStateProofID(t *testing.T) {
-	proto := config.Consensus[protocol.ConsensusFuture]
+	proto := config.Consensus[protocol.ConsensusCurrentVersion]
 
 	dbs, _ := dbOpenTest(t, true)
 	setDbLogging(t, dbs)

ledger/apply/keyreg_test.go

@@ -194,15 +194,15 @@ func TestStateProofPKKeyReg(t *testing.T) {
 
 	acct, err := mockBal.Get(tx.Src(), false)
 	require.NoError(t, err)
-	require.Equal(t, true, acct.StateProofID.IsEmpty())
+	require.True(t, acct.StateProofID.IsEmpty())
 
 	mockBal = makeMockBalances(protocol.ConsensusCurrentVersion)
 	err = Keyreg(tx.KeyregTxnFields, tx.Header, mockBal, transactions.SpecialAddresses{FeeSink: feeSink}, nil, basics.Round(0))
 	require.NoError(t, err)
 
 	acct, err = mockBal.Get(tx.Src(), false)
 	require.NoError(t, err)
-	require.Equal(t, false, acct.StateProofID.IsEmpty())
+	require.False(t, acct.StateProofID.IsEmpty())
 }
 
 func createTestTxn(t *testing.T, src basics.Address, secretParticipation *crypto.SignatureSecrets, vrfSecrets *crypto.VRFSecrets) transactions.Transaction {

test/e2e-go/restAPI/restClient_test.go

@@ -554,7 +554,7 @@ func TestAccountParticipationInfo(t *testing.T) {
 	lastRound := basics.Round(params.LastRound + 1000)
 	dilution := uint64(100)
 	var stateproof merklesignature.Verifier
-	stateproof[0] = 1 // change some byte so the stateproof is not considered empty (required since consensus v32)
+	stateproof[0] = 1 // change some byte so the stateproof is not considered empty (required since consensus v31)
 
 	randomVotePKStr := randomString(32)
 	var votePK crypto.OneTimeSignatureVerifier