Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): update multisearch code examples #370

Merged
merged 1 commit into from
Jan 30, 2023
Merged

chore(examples): update multisearch code examples #370

merged 1 commit into from
Jan 30, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Oct 27, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Related Issue n/a
Need Doc update no

Describe your change

Updates MultiSearch examples:

  • Two HitsSearchers
  • HitsSearcher and FacetsSearcher

@aallam aallam force-pushed the chore/multisearch-examples branch from 765324c to f3e30c2 Compare October 28, 2022 15:45
@aallam aallam marked this pull request as ready for review October 28, 2022 15:45
@aallam aallam requested a review from VladislavFitz October 28, 2022 15:46
VladislavFitz
VladislavFitz reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@VladislavFitz VladislavFitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the new AppTheme affect a lot the demo appearance? If yes, probably the demo gifs should be updated accordingly?

@aallam
Copy link
Member Author

aallam commented Nov 28, 2022

Will the new AppTheme affect a lot the demo appearance? If yes, probably the demo gifs should be updated accordingly?

Actually, there will be no visual change, since AppTheme is based on MaterialTheme. The idea is to have the same theme everywhere, and no need to redeclare it each time.

@aallam aallam requested a review from VladislavFitz November 28, 2022 13:05
@aallam aallam merged commit 10b9740 into master Jan 30, 2023
@aallam aallam deleted the chore/multisearch-examples branch January 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladislavFitz VladislavFitz VladislavFitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aallam @VladislavFitz