Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): body is not required in multiple batch request #3454

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Aug 2, 2024

🧭 What and Why

For multipleBatch requests, the body property can be empty if the action is delete or clear, thus, it shouldn't be marked as required.

Changes included:

  • Remove body from the list of required properties for the multipleBatch operation.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 2, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 40d16ae5ba1c621b53111f0e0ab82eae85f4c88a
🍃 Generated commit f6341d0e43f9f4b87a1ceb541ec39f7a50ef605f
🌲 Generated branch generated/fix/batch-ops
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1400
php 1307
csharp 1091
java 877
ruby 854
python 755
swift 737
go 467
kotlin 444

Copy link

github-actions bot commented Aug 2, 2024

@kai687 kai687 marked this pull request as ready for review August 2, 2024 13:29
@kai687 kai687 requested a review from a team as a code owner August 2, 2024 13:29
@millotp millotp merged commit 7af1e75 into main Aug 3, 2024
21 checks passed
@millotp millotp deleted the fix/batch-ops branch August 3, 2024 07:13
algolia-bot added a commit that referenced this pull request Aug 3, 2024
…enerated) [skip ci]

Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 3, 2024
algolia/api-clients-automation#3454

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants