Suggest to replace maxminddb gem with maxmind-geoip2 #1538
Replies: 2 comments 3 replies
-
|
Yes, thanks for pointing this out. I agree. Open to pull requests. |
Beta Was this translation helpful? Give feedback.
-
|
Excellent. I'll give it a stonking red hot go. Strap yourself in. |
Beta Was this translation helpful? Give feedback.
-
|
Strapped, belted, and braced. Do your worst. |
Beta Was this translation helpful? Give feedback.
-
|
Argh... This turned out to be trickier than I thought. It would appear that the maxminddb gem and the hive_geoip2 gem had very similar methods and syntax. This isn't the case with the maxmind-geoip2, meaning that either I have to mangle things together, and end up with an inelegant solution, or split support for maxmind-geoip2 into its own separate thing (which seems a bit silly). I'm going to need to have a think a breather... |
Beta Was this translation helpful? Give feedback.
-
|
No worries, take your time. I haven't looked at this in detail but it's possible it's too complex to be worth doing at the moment. |
Beta Was this translation helpful? Give feedback.
-
Currently geocoder requires the maxminddb gem which does not look like it has had an update in several years. I suggest using the official maxmind-geoip2 which is getting regular updates.
Beta Was this translation helpful? Give feedback.
All reactions