upgrade for 0.11 #116
Closed
upgrade for 0.11 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinwoo
force-pushed
the
0.11
branch
4 times, most recently
from
1b5eb6d to
b43b04c
Compare
|
updated node target version to 6 since 5 doesn't run the install script and the new LTS is 6 anyhow. |
sloosch
suggested changes
Apr 29, 2017
src/Pux/Router.purs
Outdated
| @@ -151,7 +151,7 @@ parseQuery s = Query <<< M.fromFoldable <<< catMaybes <<< map part2tuple $ parts | |||
| part2tuple :: String -> Maybe (Tuple String String) | |||
| part2tuple part = do | |||
| let param' = S.split (S.Pattern "=") part | |||
| guard $ A.length param' == 2 | |||
| _ <- guard $ A.length param' == 2 | |||
There was a problem hiding this comment.
you don't need to discard Unit explicitly. import Prelude.discard
| @@ -59,11 +59,11 @@ start config = do | |||
| htmlSignal = stateSignal ~> config.view | |||
| mapAffect affect = launchAff $ unsafeCoerceAff do | |||
| ev <- affect | |||
| later $ case ev of | |||
There was a problem hiding this comment.
later was replaced with delay (purescript-contrib/purescript-aff@1ed0d75)
delay (Milliseconds 0.0) should therefore be placed above the case
There was a problem hiding this comment.
seems like a smell, but yeah, updated
src/Pux.purs
Outdated
| Nothing -> pure unit | ||
| Just e -> liftEff $ send evChannel (singleton e) | ||
| effectsSignal = effModelSignal ~> map mapAffect <<< _.effects | ||
| runSignal $ effectsSignal ~> sequence_ | ||
| _ <- runSignal $ effectsSignal ~> sequence_ |
There was a problem hiding this comment.
you don't need to discard Unit explicitly. import Prelude.discard
|
updated with @sloosch's suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.