Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

targetValue doesn't check for undefined value #119

Closed
mbid opened this issue May 7, 2017 · 0 comments
Closed

targetValue doesn't check for undefined value #119

mbid opened this issue May 7, 2017 · 0 comments
Labels
bug

Comments

@mbid
Copy link

mbid commented May 7, 2017

Just browsing the source code, I found that targetValue checks only whether event.target is undefined and not whether event.target.value is. But e.g. h1 elements don't have values while you can attach click listeners to it. The fix is trivial of course, but I don't know whether there are also other places where this issue occures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexmingoia @mbid