Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate charts for download / upload (or mixed axis chart) #258

Closed
zvarg opened this issue Dec 21, 2022 · 12 comments · Fixed by #1225
Closed

Separate charts for download / upload (or mixed axis chart) #258

zvarg opened this issue Dec 21, 2022 · 12 comments · Fixed by #1225
Assignees
Labels
🎉 feature New feature or request

Comments

@zvarg
Copy link

zvarg commented Dec 21, 2022

Is your feature request related to a problem? Please describe.
Speedtest results on an asymetric connection can be visually frustrating. I have 1000/40 Mbps down/up speed the nearly representing two horisontal lines. Impossible to see drops.

image

Describe the solution you'd like
The chart could have a second axis. One for download and one for upload speed. Displaying would be more representating because of the smaller thresholds.

Additional context
If the implementation of the the axis chart is problematic, maybe an option for a separate chart would be welcome for down/up speed.

@alexjustesen
Copy link
Owner

For later Alex to reference https://www.chartjs.org/docs/latest/samples/line/multi-axis.html

@alexjustesen
Copy link
Owner

I did also take a little stab at this while I had 5min and at first pass the lines overlap perfectly which is less than ideal...
image

Might have to enforce starting the chart from zero again?
image

Open to feedback on this one...

@zvarg
Copy link
Author

zvarg commented Dec 21, 2022

I was looking for something like the last one. Different min and max for each axis is a must have.

Just thinking...

Starting from zero? Maybe determine min and max dynamically? E.g.: on 1000/40: Download speed would be between 800 and 1100 most of the time, while up speed would be between 0 and 50.

Determine min and max for down speed axis
Min: min(of all data of down speed tests) - 20 or 0 if negative
Max: max(of all data of down speed tests) + 20
Same for up speed.

Something like that.

@alexjustesen
Copy link
Owner

Maybe instead of hard coding these constraints they're prime to configure in the settings. For some (my real connection) I'm 1000/1000 so the dynamic charts are better.

@zvarg
Copy link
Author

zvarg commented Dec 21, 2022

Yes, avoid constants from example (1100, 800, 50,0) Also 20 can be comes from settings. I am not a UX expert, but that can be calculated dynamically too. For example x% of the min and same for max. But that's another profession.

@alexjustesen
Copy link
Owner

So the charts on the dash are powered by Chartjs so it can be extended to anything that lib supports. I'll keep thinking about it.

@alexdelprete
Copy link
Contributor

alexdelprete commented Dec 22, 2022

Dynamic limits and single/double Y axis in the options would adapt the graphs to many use-cases.

For more advanced stuff, I'd suggest users to use influx data + grafana (a dashboard is already available), much more flexible and powerful.

@alexjustesen
Copy link
Owner

For more advanced stuff, I'd suggest users to use influx data + grafana (a dashboard is already available), much more flexible and powerful.

I think it was in a discussion but this is my recommendation as well. In this case I think cleaning up the UI is a good idea but for advanced charting and anything custom I would recommend an external solution.

@zvarg
Copy link
Author

zvarg commented Dec 22, 2022

Since Chartjs is supporting our discussion. Your opinion with starting the grid with zero would be perfect as resolve the feature request. I wait for more feature request about the charts before starting to think big and starting to use another 3rd party packages and libraries.

@alexjustesen What do you think? Are you seeing the example #2 you provided as an easily implementable solution and can we wait for it in relatively short time? In any way, thanks in advance.

@alexjustesen
Copy link
Owner

alexjustesen commented Dec 22, 2022

I'm not going to set a date on when more chart enhancements will be out especially with the holidays coming up.

I've had a bunch of small enhancements and issues over the last couple weeks that have prevented me from starting on backup/import/export which I see as more important than tweaking the UI at this time.

@zvarg
Copy link
Author

zvarg commented Dec 22, 2022

Of course. Enjoy your holiday. As always, feature request should be priorized and more important issues and features comes first.

@alexjustesen alexjustesen self-assigned this Jan 4, 2023
@alexjustesen alexjustesen added the 🎉 feature New feature or request label Jan 4, 2023
@alexjustesen alexjustesen modified the milestones: v0.10.0, v0.12.0 Jan 4, 2023
@luckman212
Copy link

Not sure if this FR is still being considered, but for example, on my 1G connection, I would prefer if those big purple dips weren't so severe looking. A y axis that was anchored (0-based) would be my preference...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants