Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing correct status for the speed tests going to run on servers which do not exist anymore #1743

Closed
armond-avanes opened this issue Oct 7, 2024 · 4 comments · Fixed by #1679

Comments

@armond-avanes
Copy link

armond-avanes commented Oct 7, 2024

The issue of "Started but not completed" speed tests has been discussed in a couple of other tickets including the following:
#1591

My request is that SpeedTest-Tracker shows the correct status for such failed tests, instead of just showing "Started" with no further data or error message for that record. Something like "Server not exist/available" and the Server ID should also be included on the record. Or the status could be "Error" with some description/comment on that test record explaining the actual failure reason (no such server ID exists).

Currently the only thing you see are the timestamp and the test ID. By seeing the Server ID and the correct status, admins will be able to quickly identify the servers which do not exist anymore. And if it happens all the time for the same server(s), they'll know that they need to remove those servers from the servers list.

@svenvg93
Copy link
Contributor

svenvg93 commented Oct 7, 2024

This will be fixed with the merge of #1679
It will show the correct status, server id and the error message returned by the Ookla client.

@armond-avanes
Copy link
Author

Thank you! The PR is exactly what I need!

Is there any ETA on when you're planning to merge it? Looks like you've been going back and forth on this PR for the past two months.

@svenvg93
Copy link
Contributor

svenvg93 commented Oct 7, 2024

Not really, I'm not the one merging it, as im not the owner. In the last review by Alex, it was found that not all senarios where covered in it. That should be the case now. Its waiting for Alex to review, test it again before merging it. But he is very busy so it might take some time.

@armond-avanes
Copy link
Author

@alexjustesen Is there any ETA for the PR discussed above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants