Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an "allowList" feature #7

Closed
pzi opened this issue Aug 26, 2020 · 2 comments · Fixed by #8
Closed

Adding an "allowList" feature #7

pzi opened this issue Aug 26, 2020 · 2 comments · Fixed by #8

Comments

@pzi
Copy link
Collaborator

pzi commented Aug 26, 2020

Hi Alex,

As we are continuing to work with ECR vulnerability scanning, we came across some vulnerabilities (incl. false positives) we cannot fix but also won't impact the security of our image as we wouldn't be using that certain feature (e.g. docker-library/wordpress#472).

Given this, we are thinking of implementing an allow-list feature, where we can maintain an array of references to vulnerabilities we want to ignore in the counts.

Is that something you have considered yourself in the past maybe? Would you be interested in accepting a PR for it in the near future?

Cheers
Patrik

@alexjurkiewicz
Copy link
Owner

alexjurkiewicz commented Aug 26, 2020

We haven't had any issues like this with our own images. Well, we have given up using medium as a threshold for some images 🙊

I think this feature makes sense. And +1 for the modern inclusive name. Were you thinking of using CVE as the identifier?

To prevent the user's allow list growing forever, this action should warn (or error??) if a CVE is allowed that is not in the vulnerability list at a failing threshold.

@pzi
Copy link
Collaborator Author

pzi commented Aug 26, 2020

Haven't thought that far ahead, but yeah "CVE name" as the identifier seems to make sense. Will have to have a closer look to what the response is that comes back from ECR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants