Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush / streaming #186

Closed
freimer opened this issue Nov 12, 2023 · 2 comments
Closed

Flush / streaming #186

freimer opened this issue Nov 12, 2023 · 2 comments

Comments

@freimer
Copy link

freimer commented Nov 12, 2023

It does not appear that this supports streaming, or the ability to flush the writer. The sessionResponseWriter is not exported (lowercase), so we can't get at the underlying ResponseWriter (w), nor can we call the Unwrap (because we would need to type assert and we can't because sessionResponseWriter is not exported. So bit of a quandary here, unless I'm just missing something. Would it be possible to implement http.Flusher?

@freimer
Copy link
Author

freimer commented Nov 12, 2023

Read #141 and implemented the ResponseController. Everything works. I suggest some (prominent) note be added in the docs. Either it is not there, or I missed it. Feel free to close this issue, leaving it open so the request to put in docs is noticed...

@alexedwards
Copy link
Owner

Done! https://github.com/alexedwards/scs#flushing-and-streaming-responses

Thanks for the suggestion 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants