-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove need for datasets fork #6
Comments
TODO: we need from_yaml_dict to load the bio features if we override Features then from_dataset_card_data doesn't need overriding: DatasetInfosDict.from_dataset_card_data gets invoked in module factory. |
basically just modifying from from yaml list, to yaml list, from arrow schema and to arrow schema should handle everything it's tricky to get everything working with anything other than a direct features override - Features is hardcoded in InfosDict, which in turn is hard coded in module factory |
The point is that there are two cases:
What guides the serialisation, what is the flow etc.
this also happens in Dataset init
inferred_features = Features.from_arrow_schema(arrow_table.schema)
load_dataset_builder
builder_instance.as_streaming_dataset
builder_instance.download_and_prepare
builder_instance.as_dataset
The text was updated successfully, but these errors were encountered: