Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default port for Prometheus metrics endpoint to 9100 #129

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

tillprochaska
Copy link
Contributor

@tillprochaska tillprochaska commented Nov 8, 2023

In practice, this doesn’t make a huge difference, but port 9090 is conventionally used for the Prometheus server.

Port 9090 is conventionally used for the Prometheus server.
@tillprochaska tillprochaska requested a review from stchris November 8, 2023 16:09
Copy link
Contributor

@stchris stchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It seems that the GHA runner images previously came with setuptools pre-installed, but that’s not the case anymore, causing builds to fail…
@tillprochaska tillprochaska force-pushed the fix/prometheus-metrics-port branch 2 times, most recently from 7c89390 to 5882abf Compare November 13, 2023 22:41
@tillprochaska tillprochaska merged commit 45f3de8 into main Nov 14, 2023
2 checks passed
@tillprochaska tillprochaska mentioned this pull request Nov 17, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants