Add additional confirmation UI before destructive actions #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tally deleting a collection
…tally deleting entity sets
tillprochaska
changed the title
Rosencrantz
approved these changes
Apr 25, 2023
| values={{ type }} | ||
| /> | ||
| )} | ||
| </> |
There was a problem hiding this comment.
Nitpick. To me it would be better to create a set of values and then make only one element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we had to handle multiple support cases of users deleting collections and entity sets by accident. In some cases, this was because users thought they were only deleting an entity within the investigation or entity set. Even though we do show a confirmation dialog before destructive actions, users often do not read the actual dialog message.
In order to prevent users from deleting data by accident, this PR adds an additional confirmation UI before deleting collections or entity sets and asks users to confirm the title of the collection/investigation.
The following video shows the flow to delete a collection:
Screen.Recording.2023-04-24.at.19.08.19.mov
The flows for deleting entity sets (diagrams, lists, timelines, profiles) use a similar UI:
To do:
DeleteDialogcomponent to reduce redundancyCloses #2334