Reauthenticate user in test to update session cache

452e46 changes the way we handle authentication in tests. Previously, we used API keys to authenticate users. Now, as we don’t generate API keys for users by default anymore, we use session tokens (the same mechanism the UI uses as well). In general, authentication using session tokens and API keys is quite similar: In both cases, the token is passed as a request header.

However, there’s one significant difference between session tokens and API keys: When using API keys, data about the user (including group memberships) is loaded from the database on every request. When using session tokens, this data is cached in Redis for the lifetime of the session. For end users, this means they have to sign out and in again after their group memberships have been updated.

When I originally implemented this change in our tests, it didn’t affect any of the tests as none of them did rely on updating group memberships. However, I’ve since implemented and merged additional tests in #3865, including one test that covers updating the user’s group memberships after the initial sign in. When I rebased this branch to include these new tests, this particular test failed.

The solution for this is the same as for end users: In the test case, we need to reauthenticate the test user after updating the group memberships.

Author: tillprochaska

aleph/tests/test_permissions_api.py

@@ -94,6 +94,16 @@ def test_update_groups(self):
         assert res.json["results"][0]["role"]["id"] == str(self.role.id)
 
         self.role.add_role(group)
+
+        # The user's group memberships are cached in Redis when the user signs in.
+        # As we've updated the group memberships, we need to reauthenticate the
+        # user to update the cache.
+        self.role, self.headers = self.login(
+            foreign_id="john",
+            name="John Doe",
+            email="john.doe@example.org",
+        )
+
         res = self.client.put(url, headers=self.headers, json=data)
         assert res.status_code == 200
         assert len(res.json["results"]) == 2