Fix: Orchestrator failed with assert result["result"] == HTTPOk.status_code

Problem:

The diagnostic VM returned HTTP 200 with {"result": False} when it could not connect to the internet.

Since this is an OK return code, `raise_for_status` did not raise an error and an assertion error was raised.

Solution:

Test that the returned status code also corresponds to HTTP OK.

Author: hoh

src/aleph/vm/orchestrator/status.py

@@ -119,8 +119,15 @@ async def check_internet(session: ClientSession, vm_id: ItemHash) -> bool:
     """Check that the VM has internet connectivity. This requires DNS, IP, HTTP and TLS to work."""
     try:
         result: dict = await get_json_from_vm(session, vm_id, "/internet")
-        assert result["result"] == HTTPOk.status_code
+
+        # The HTTP Header "Server" must always be present in the result.
         assert "Server" in result["headers"]
+
+        # The diagnostic VM returns HTTP 200 with {"result": False} when cannot connect to the internet.
+        # else it forwards the return code if its own test endpoint.
+        if result.get("result") != HTTPOk.status_code:
+            return False
+
         return True
     except ClientResponseError:
         return False