Remove double declaration of ethereum dependencies #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we certain that neither of these libraries is used for something outside ethereum ? |
…account` to avoid importing `aleph.sdk.chains.ethereum` by default
|
Now I'm certain, |
|
There still seems to be some place where the ethereum dependencies are being imported by default in |
|
Failed to retrieve llama text: POST 404: File Not Found |
|
Closing this as important foundation messages are signed with ETH and might need to be validated in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only required if installed with
pip install aleph-sdk-python[ethereum].