Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/indexer backpressure #36

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Fix/indexer backpressure #36

merged 4 commits into from
Apr 25, 2023

Conversation

MHHukiewitz
Copy link
Member

Fixes #33.

  • Added docs and a new parameter maxQueueSize to the PendingWorkPool class.
  • EntityFetcher now has a maxQueueSize on its pendingEntities work pool, to avoid flooding the DB with pending requests

ricardocr987
ricardocr987 reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@ricardocr987 ricardocr987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 088a55a into main Apr 25, 2023
@MHHukiewitz MHHukiewitz deleted the fix/indexer-backpressure branch April 25, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardocr987 ricardocr987 ricardocr987 left review comments

@amalcaraz amalcaraz Awaiting requested review from amalcaraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Backpressure gracefully
2 participants
@MHHukiewitz @ricardocr987