Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyling v1 #38

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Restyling v1 #38

wants to merge 3 commits into from

Conversation

MHHukiewitz
Copy link
Member

To be improved.

Copy link

Copy link

@hoh
Copy link
Member

hoh commented Nov 17, 2023

Great job !

The combination of the horizontal and vertical navbars make navigation less heavy, but also harder to navigate (more clicks) 🤔

Why renaming "Computing" -> "VMs" ?

I have a weird glitch when switching pages, it goes through a dark appearance that is very disturbing. Any idea what can be causing that ? (on Firefox)

The light grey footer at the bottom is not very readable.

@claudioALEPH
Copy link
Member

I would like to wait with publishing this until we fine-tuned the theme to be fully aleph branded.

@MHHukiewitz
Copy link
Member Author

I would like to wait with publishing this until we fine-tuned the theme to be fully aleph branded.

But the current one HURRRRTS MY EYEEEEEs

@MHHukiewitz
Copy link
Member Author

Great job !

Thanks! :)

The combination of the horizontal and vertical navbars make navigation less heavy, but also harder to navigate (more clicks) 🤔

I found the left navigation bar overwhelming and too spread out across topics. Over time, there will only be more pages on the various topics, which might require refactoring at some point.

Why renaming "Computing" -> "VMs" ?

It is a more concrete description of what this chapter entails. "Computing" sounds too generic.

I have a weird glitch when switching pages, it goes through a dark appearance that is very disturbing. Any idea what can be causing that ? (on Firefox)

Like a short flash before going back to normal?

The light grey footer at the bottom is not very readable.

I also noted this, will change 👍

@MHHukiewitz
Copy link
Member Author

MHHukiewitz commented Nov 20, 2023

@claudioALEPH Also, what would it take to get there? Do we really have to wait until January? Would it be fine to have this merged on a different branch, but without the CSS?

@claudioALEPH
Copy link
Member

@claudioALEPH Also, what would it take to get there? Do we really have to wait until January? Would it be fine to have this merged on a different branch, but without the CSS?

Yes, of course, that would be great. The problem I have is that we're introducing yet another theme here, which I want to avoid. We have already too many things that are off brand, and we've been working hard to get everything aligned.

@MHHukiewitz
Copy link
Member Author

@hoh @claudioALEPH Made another PR without the CSS changes here: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants