Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring for increased modularity #2

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

dmarx
Copy link

@dmarx dmarx commented Feb 28, 2022

One of my main goals with PyTTI is to develop a library that facilitates building generative art colabs. towards that end, I'm hoping to use DD as a target to try to see what "implemented on top of PyTTI" might look like. My main goal with this refactor is to better understand what components of disco are really DD specific, vs what parts might be more general purpose. My opinion is that generally useful stuff should be modularized as much as possible to facilitate reuse, and moreover that the notebooks themselves should really just be a UI with the code that "does stuff" moved to a separate backend codebase, model-view-controller paradigm for colab notebooks.

Enough preamble. Here are a few of the major changes:

  • Updated some dependencies to be installed to reduce namespace collisions and eliminate need for changing directory for imports
  • moved a bunch of code into modules, which required moving some variables into call signatures that otherwise were being invoked from the global namespace

@dmarx
Copy link
Author

dmarx commented Feb 28, 2022

NB: as of this writing, testing has basically been limited to making sure the modified notebook here runs. Also be advised: the notebook in this branch currently clones from this dev repo/branch, which will need to be changed prior to a merge if y'all are inclined to incorporate any of this

@dmarx
Copy link
Author

dmarx commented Feb 28, 2022

Oh yeah also a general tip: pip install -e isn't always supported. Better to just use pip install. I think that's why taming or CLIP wasn't being installed correctly, for example. some discussion here: pypa/pip#7265

" !git clone https://github.com/alembics/disco-diffusion.git\n",
" #!git clone https://github.com/alembics/disco-diffusion.git\n",
"\n",
" !git clone --branch pytti-disco https://github.com/pytti-tools/disco-diffusion.git\n",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmarx
Copy link
Author

dmarx commented Jul 17, 2022

@GraphtyLove NB: this PR was suggested 5 months ago and has been stale since then. If this refactor is something you're interested in incorporating, it will take some additional work to apply these changes to the current code base.

aletts pushed a commit that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants