-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring for increased modularity #2
base: main
Are you sure you want to change the base?
Conversation
NB: as of this writing, testing has basically been limited to making sure the modified notebook here runs. Also be advised: the notebook in this branch currently clones from this dev repo/branch, which will need to be changed prior to a merge if y'all are inclined to incorporate any of this |
Oh yeah also a general tip: |
" !git clone https://github.com/alembics/disco-diffusion.git\n", | ||
" #!git clone https://github.com/alembics/disco-diffusion.git\n", | ||
"\n", | ||
" !git clone --branch pytti-disco https://github.com/pytti-tools/disco-diffusion.git\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GraphtyLove NB: this PR was suggested 5 months ago and has been stale since then. If this refactor is something you're interested in incorporating, it will take some additional work to apply these changes to the current code base. |
One of my main goals with PyTTI is to develop a library that facilitates building generative art colabs. towards that end, I'm hoping to use DD as a target to try to see what "implemented on top of PyTTI" might look like. My main goal with this refactor is to better understand what components of disco are really DD specific, vs what parts might be more general purpose. My opinion is that generally useful stuff should be modularized as much as possible to facilitate reuse, and moreover that the notebooks themselves should really just be a UI with the code that "does stuff" moved to a separate backend codebase, model-view-controller paradigm for colab notebooks.
Enough preamble. Here are a few of the major changes: