Release-start and release-finish doesn't check for SNAPSHOT dependencies on submodules

[nickstolwijk]

I'm trying out the gitflow-maven-plugin and I'm encountering the following:

I have a project setup with a aggregator pom in the root, a configuration pom in configuration/ and various modules for the functionality, which all have the configuration pom as parent. In the configuration pom all the dependencies are under build/dependencies instead of build/dependencyManagement. This is because the dependencies of the configuration pom are added to the Tycho targetplatform.

If I run mvn gitflow:release-start on the aggregator pom, I see the logging "INFO : Checking for SNAPSHOT versions in dependencies.", but it finishes without seeing the SNAPSHOT-dependencies of the configuration pom. I believe this is because it checks only the dependencies of the aggregator project and not of the other projects in the tag.

Is this by design or should the check for snapshot stage also check the projects under the tag for SNAPSHOTS? (And the modules under the modules tag can have sub-modules, so it should be recursive if that is the case)

[aleksandr-m]

Currently it doesn't check for snapshots in modules. But it probably should. Let's see if getting projects from MavenSession will resolve it.

[Yeggstry]

Hi,

Is there any plans for including this change into a release? My company are currently evaluating various maven gitflow release plugins and really like that this is still being actively developed. This change would be a great help for us as we have a lot of multi-module maven projects in our codebase.

Thanks,

Lewis

[aleksandr-m]

@Yeggstry Sure. It is good time to release. :) I'll try to do it in a next few days.

[aleksandr-m]

@nickstolwijk @Yeggstry 1.4.0 is released. Enjoy.

[Yeggstry]

Thanks a lot :)

[thaDude]

Hello, the check does not seem to detect if the parent project dependency is a snapshot version. Is this by design?

Example, a project's pom.xml which contains:

<parent>
    <groupId>com.acme.build</groupId>
    <artifactId>my-maven-parent</artifactId>
    <version>0.0.10-SNAPSHOT</version>
</parent>

^ Does not fail release-* goals regardless o -DallowSnapshots=true/false

Thank you.

[aleksandr-m]

@thaDude See #64. If you can create small example project it would help.