Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not merge to master for release-finish #107

Closed
ismarslomic opened this issue Apr 29, 2018 · 6 comments
Closed

Option to not merge to master for release-finish #107

ismarslomic opened this issue Apr 29, 2018 · 6 comments

Comments

@ismarslomic
Copy link

ismarslomic commented Apr 29, 2018

Hi, thanks for great plugin!

Is it possible to do the merge, for goal release-finish, only to development (develop), but not production (master)? We don´t want to merge an release to master branch which is not yet tested (performance test, manual tests, etc) in an test environment. In addition we do not allow push to master without Pull Requests.

Since release-finish goal automatically merge to develop and master, after creating an release, it is difficult to achieve this.

Any suggestions?

@aleksandr-m
Copy link
Owner

Looks same as #97. Why not to use git merge? Also if it not a release branch really, then why not to call it a feature branch?

@ismarslomic
Copy link
Author

ismarslomic commented May 2, 2018

Good point! The only advantage of using release branch is because we do actually releases from this branch and we also get auto-merge feature to develop-branch within Atlassian Bitbucket, when we create Pull Requests to merge from bugfix -> release branch

@hypery2k
Copy link

hypery2k commented Apr 9, 2019

having the same issue here. Any new thoughts here?

@aleksandr-m
Copy link
Owner

@hypery2k Do you really need a release branch? Feature/support/hotfix/some other branch maybe?

BTW the hotfix-finish goal has skipMergeProdBranch option since 1.12.0.

@hypery2k
Copy link

hypery2k commented Jun 4, 2019

I'm using the option for now, so from my side no need for the issue as it can be resolved with the help of the option

@aleksandr-m
Copy link
Owner

Duplicate of #74, which is resolved by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants