-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] v.redd.it video files: No webm source file found #5
Comments
Before, the process was adding both a source for webm and mp4 videos. But this was an issue since not every source provide the 2 formats. Thus making the rendering quite unusable when in third-party tools. Now, the mp4 format is preferred. On top of that the URL is checked before being added to the video tag. It's a bit longer to process but it's much safer since all URL are validated beforehand. See #5
@rom-1 I've made a fix. It's not released yet but you can still try it out. Let me know if it works the way you've intended. Thank you! |
@aledeg I gave it a shot, seems to work flawless. I had no chance to test it with other sources then v.redd.it, as nowadays 99% of reddits media content seems to come from there. But all these videos are now showing up in my RSS Reader app without any problems. Before they had an error "source not found". Thank you very much. :) |
Good! Did you notice if loading is longer? |
Yea, I took a look at the source code you changed, and already saw that you are now checking for the http status return code before building the html source code. While this approach is promising to be very low-maintenance (peu d'entretien?), it should naturally increase loading times. But I agree, it is barely noticeable, so this works for me. Thanks a lot! :) // Side Note - Offtopic To be honest, I am afraid in the future you might not be able avoid this manual approach, as there might be other sources which require special handling, or might need specially crafted source urls. I know your extension is focusing on image handling, but you are also displaying other content types like gifs, text and videos from external sources (which is great! 😀). // Side Note 2 - very offtopic |
I am afraid I will someday do something similar to what you've mentioned. I not eager to do it though. You're not getting on my nerves. But thank you for asking. |
When embedding video content from v.redd.it, there are currently 2 source urls used: one for .webm and one for a .mp4 file.
Example code:
While this works for some media platforms, e.g. gfycat.com, it does not work with v.redd.it, as this platform is simply not offering a .webm file. This means currently there is a broken link as a source file referenced, and some 3rd party clients throw an error in this case. A clean solution would be to only reference the mp4 file.
See #4 for additional information
The text was updated successfully, but these errors were encountered: