~

Author: alecrabbit

example/async/bootstrap.async.php

@@ -29,10 +29,7 @@ static function (IContainer $container): IDriverLinker {
         },
         IServiceDefinition::SINGLETON,
     ),
-);
-
-// Register driver linker with output factory
-$registry->bind(
+    // Register driver linker decorator factory
     new ServiceDefinition(IDriverLinkerDecoratorFactory::class, DriverLinkerDecoratorFactory::class),
 );
 

example/benchmark/container.php

@@ -45,32 +45,28 @@
 
 $registry = DefinitionRegistry::getInstance();
 
-$registry->bind(new ServiceDefinition(ITimer::class, new MicrosecondTimer()));
-$registry->bind(new ServiceDefinition(IDriverProviderFactory::class, BenchmarkingDriverProviderFactory::class));
-$registry->bind(new ServiceDefinition(IResultMaker::class, ResultMaker::class));
-$registry->bind(new ServiceDefinition(IBenchmarkResultsFactory::class, BenchmarkResultsFactory::class));
-$registry->bind(new ServiceDefinition(IBenchmarkingDriverFactory::class, BenchmarkingDriverFactory::class));
-$registry->bind(new ServiceDefinition(IBenchmarkingDriverBuilder::class, BenchmarkingDriverBuilder::class));
-$registry->bind(new ServiceDefinition(IBenchmarkFactory::class, BenchmarkFactory::class));
-$registry->bind(new ServiceDefinition(IMeasurementFactory::class, MeasurementFactory::class));
-$registry->bind(new ServiceDefinition(IStopwatchBuilder::class, StopwatchBuilder::class));
-$registry->bind(new ServiceDefinition(IStopwatchFactory::class, StopwatchFactory::class));
-$registry->bind(new ServiceDefinition(IReportPrinterBuilder::class, ReportPrinterBuilder::class));
-$registry->bind(new ServiceDefinition(IReportFormatter::class, ReportFormatter::class));
-$registry->bind(new ServiceDefinition(IDatetimeFormatter::class, DatetimeFormatter::class));
-$registry->bind(new ServiceDefinition(IResultFormatter::class, ResultFormatter::class));
-$registry->bind(new ServiceDefinition(IKeyFormatter::class, KeyFormatter::class));
-
 $registry->bind(
+    new ServiceDefinition(ITimer::class, new MicrosecondTimer()),
+    new ServiceDefinition(IDriverProviderFactory::class, BenchmarkingDriverProviderFactory::class),
+    new ServiceDefinition(IResultMaker::class, ResultMaker::class),
+    new ServiceDefinition(IBenchmarkResultsFactory::class, BenchmarkResultsFactory::class),
+    new ServiceDefinition(IBenchmarkingDriverFactory::class, BenchmarkingDriverFactory::class),
+    new ServiceDefinition(IBenchmarkingDriverBuilder::class, BenchmarkingDriverBuilder::class),
+    new ServiceDefinition(IBenchmarkFactory::class, BenchmarkFactory::class),
+    new ServiceDefinition(IMeasurementFactory::class, MeasurementFactory::class),
+    new ServiceDefinition(IStopwatchBuilder::class, StopwatchBuilder::class),
+    new ServiceDefinition(IStopwatchFactory::class, StopwatchFactory::class),
+    new ServiceDefinition(IReportPrinterBuilder::class, ReportPrinterBuilder::class),
+    new ServiceDefinition(IReportFormatter::class, ReportFormatter::class),
+    new ServiceDefinition(IDatetimeFormatter::class, DatetimeFormatter::class),
+    new ServiceDefinition(IResultFormatter::class, ResultFormatter::class),
+    new ServiceDefinition(IKeyFormatter::class, KeyFormatter::class),
     new ServiceDefinition(
         IReportPrinter::class,
         static function (ContainerInterface $container): IReportPrinter {
             return $container->get(IReportPrinterFactory::class)->create();
         }
     ),
-);
-
-$registry->bind(
     new ServiceDefinition(
         IReportPrinterFactory::class,
         static function (ContainerInterface $container): IReportPrinterFactory {

example/benchmark/container.sync.php

@@ -22,9 +22,6 @@ public function write(Traversable $data): void
             }
         }
     ),
-);
-
-$registry->bind(
     new ServiceDefinition(
         IDeltaTimer::class,
         new class() implements IDeltaTimer {

src/Spinner/Container/Contract/IDefinitionRegistry.php

@@ -13,5 +13,5 @@ interface IDefinitionRegistry
      */
     public function load(): Traversable;
 
-    public function bind(IServiceDefinition $serviceDefinition): void;
+    public function bind(IServiceDefinition ...$serviceDefinitions): void;
 }

src/Spinner/Container/DefinitionRegistry.php

@@ -36,8 +36,10 @@ public function load(): Traversable
         yield from $this->definitions;
     }
 
-    public function bind(IServiceDefinition $serviceDefinition): void
+    public function bind(IServiceDefinition ...$serviceDefinitions): void
     {
-        $this->definitions->offsetSet($serviceDefinition->getId(), $serviceDefinition);
+        foreach ($serviceDefinitions as $serviceDefinition) {
+            $this->definitions->offsetSet($serviceDefinition->getId(), $serviceDefinition);
+        }
     }
 }

tests/Spinner/Unit/Container/DefinitionRegistryTest.php

@@ -79,6 +79,45 @@ private function getServiceDefinitionMock(): MockObject&IServiceDefinition
         return $this->createMock(IServiceDefinition::class);
     }
 
+    #[Test]
+    public function definitionCanBeBoundAsMultipleParams(): void
+    {
+        $registry = $this->getTesteeInstance();
+
+        $serviceDefinition1 = $this->getServiceDefinitionMock();
+        $serviceDefinition1
+            ->expects(self::once())
+            ->method('getId')
+            ->willReturn('service1')
+        ;
+        $serviceDefinition2 = $this->getServiceDefinitionMock();
+        $serviceDefinition2
+            ->expects(self::once())
+            ->method('getId')
+            ->willReturn('service2')
+        ;
+        $serviceDefinition3 = $this->getServiceDefinitionMock();
+        $serviceDefinition3
+            ->expects(self::once())
+            ->method('getId')
+            ->willReturn('service3')
+        ;
+
+        $registry->bind(
+            $serviceDefinition1,
+            $serviceDefinition2,
+            $serviceDefinition3
+        );
+
+        $definitions = iterator_to_array($registry->load());
+
+        self::assertCount(3, $definitions);
+
+        self::assertSame($serviceDefinition1, $definitions['service1']);
+        self::assertSame($serviceDefinition2, $definitions['service2']);
+        self::assertSame($serviceDefinition3, $definitions['service3']);
+    }
+
     #[Test]
     public function definitionCanBeOverridden(): void
     {

tests/TestCase/ContainerModifyingTestCase.php

@@ -64,7 +64,7 @@ public function load(): Traversable
                 return $this->definitions;
             }
 
-            public function bind(IServiceDefinition $serviceDefinition): void
+            public function bind(IServiceDefinition ...$serviceDefinitions): void
             {
                 // do nothing
             }