Skip to content

Run testsuite against ext-mongo #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Feb 6, 2016
Merged

Run testsuite against ext-mongo #28

merged 25 commits into from
Feb 6, 2016

Conversation

alcaeus
Copy link
Owner

@alcaeus alcaeus commented Jan 14, 2016

This PR adds ext-mongo to the build matrix in an effort to ensure the library behaves the same as ext-mongo does. This is achieved by running the tests with ext-mongo installed.

This PR will be used to stabilize the library before moving to a stable release.

@alcaeus alcaeus mentioned this pull request Jan 16, 2016
@alcaeus alcaeus force-pushed the run-ext-mongo-tests branch 2 times, most recently from 87fbd8d to e12da91 Compare January 20, 2016 18:59
@alcaeus alcaeus force-pushed the run-ext-mongo-tests branch 4 times, most recently from 0dbee47 to 3dfe42a Compare January 28, 2016 18:42
This was referenced Jan 30, 2016
@alcaeus alcaeus force-pushed the run-ext-mongo-tests branch from 3dfe42a to dbf34d1 Compare January 30, 2016 09:15
@alcaeus
Copy link
Owner Author

alcaeus commented Feb 1, 2016

@bashofmann Can you take a look at the MongoCursor class? I had to make some changes to valid() and key() to replicate the behavior of the ext-mongo class.

@alcaeus
Copy link
Owner Author

alcaeus commented Feb 1, 2016

Note: the aggregate method is failing due to mongodb/mongo-php-library#107.

@alcaeus alcaeus force-pushed the run-ext-mongo-tests branch from a3f919e to ef93c99 Compare February 1, 2016 19:01
@bashofmann
Copy link

@alcaeus Looks good, our test suite runs successfully through with this branch

@alcaeus
Copy link
Owner Author

alcaeus commented Feb 2, 2016

@bashofmann Great, thanks!

This was referenced Feb 3, 2016
@alcaeus alcaeus force-pushed the run-ext-mongo-tests branch from 4b50ca5 to 199e9d2 Compare February 6, 2016 20:11
alcaeus added a commit that referenced this pull request Feb 6, 2016
@alcaeus alcaeus merged commit e8bb929 into master Feb 6, 2016
@alcaeus alcaeus deleted the run-ext-mongo-tests branch February 6, 2016 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants