Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace skimage affine ellipse with numpy ops #1922

Conversation

momincks
Copy link
Contributor

@momincks momincks commented Sep 12, 2024

issue: #1895 (comment)

dropping the need for skimage API within Affine bbox transformation (resize_method="ellipse") with simple numpy ops. There is no impact on time.

Summary by Sourcery

Replace skimage affine transformation with numpy operations in the bboxes_affine_ellipse function to eliminate dependency on skimage without impacting performance.

Enhancements:

  • Replace the use of skimage's matrix_transform with equivalent numpy operations for affine transformations in the bboxes_affine_ellipse function.

Copy link
Contributor

sourcery-ai bot commented Sep 12, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @momincks - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@momincks
Copy link
Contributor Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It looks like we've already reviewed the commit 453e66b in this pull request.

@momincks
Copy link
Contributor Author

Can I expect workflow approval from the maintainers?

@ternaus
Copy link
Collaborator

ternaus commented Sep 18, 2024

Tests are failing, but it is unrelated to your changes. Will take a look.

@ternaus ternaus merged commit 6a8d945 into albumentations-team:main Sep 18, 2024
2 of 17 checks passed
@ternaus
Copy link
Collaborator

ternaus commented Sep 18, 2024

@momincks Thanks for the Pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants