-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace skimage affine ellipse with numpy ops #1922
replace skimage affine ellipse with numpy ops #1922
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @momincks - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. It looks like we've already reviewed the commit 453e66b in this pull request.
Can I expect workflow approval from the maintainers? |
Tests are failing, but it is unrelated to your changes. Will take a look. |
@momincks Thanks for the Pull request! |
issue: #1895 (comment)
dropping the need for skimage API within Affine bbox transformation (resize_method="ellipse") with simple numpy ops. There is no impact on time.
Summary by Sourcery
Replace skimage affine transformation with numpy operations in the bboxes_affine_ellipse function to eliminate dependency on skimage without impacting performance.
Enhancements: