Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect_num: inconsistent binning of numerical variables in comparisons #40

Closed
RoelVerbelen opened this issue Jun 9, 2021 · 1 comment

Comments

@RoelVerbelen
Copy link

Hi Alastair,

I like the idea and the visual, but the binning implementation seems wrong:

library(inspectdf)

data1 <- data.frame(x = c(rep(0, 250), rep(1, 250)))
data2 <- data.frame(x = c(rep(0, 230), rep(1, 270)))

show_plot(inspect_num(data1, data2))

Created on 2021-06-09 by the reprex package (v1.0.0)

It even occurs for identical data:

show_plot(inspect_num(data1, data1))
@alastairrushworth
Copy link
Owner

Thanks for reporting this @RoelVerbelen ! this should now be fixed on the dev version of the package. I'll roll this into the next CRAN update within the week. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants