Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove namespace scoped using statements in generated code for model #92

Open
alashworth opened this issue Mar 12, 2019 · 0 comments
Open
Milestone

Comments

@alashworth
Copy link
Owner

Issue by bob-carpenter
Sunday Mar 27, 2016 at 03:38 GMT
Originally opened as https://github.com/stan-dev/stan/issues/1820


Summary:

See title.

Description:

We don't need those top-level using statements; we can move them to where they're needed.

Reproducible Steps:

Just look at the C++ generated for any Stan program.

Current Output:

Generates these using statements:

namespace unit_model_namespace {

using std::istream;
using std::string;
using std::stringstream;
using std::vector;
using stan::io::dump;
using stan::math::lgamma;
using stan::model::prob_grad;
using namespace stan::math;

Expected Output:

Nothing at this scope; everything pushed down to where needed or explicitly qualified in its output.

Current Version:

v2.9.0

@alashworth alashworth added this to the v3 milestone Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant