Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax requirement on final / in include paths #183

Open
alashworth opened this issue Mar 12, 2019 · 3 comments
Open

relax requirement on final / in include paths #183

alashworth opened this issue Mar 12, 2019 · 3 comments

Comments

@alashworth
Copy link
Owner

Issue by bob-carpenter
Tuesday Feb 20, 2018 at 18:19 GMT
Originally opened as stan-dev/stan#2472


Summary:

The include path mechanism currently appends the file name to the path, which requires the path to end in /. Instead, check if the path ends in a separator, and if not, add one.

@ahartikainen originally brought this up in: https://github.com/stan-dev/pystan/pull/438#issuecomment-367004027

Current Version:

v2.17.1

@alashworth
Copy link
Owner Author

Comment by bgoodri
Wednesday Feb 21, 2018 at 02:17 GMT


Also, if it cannot find the #included file, the error message should reference the file name that it did not find.

@alashworth
Copy link
Owner Author

Comment by ariddell
Saturday Mar 31, 2018 at 16:13 GMT


Should the milestone for this be bumped? This would be great to get in.

@alashworth
Copy link
Owner Author

Comment by ahartikainen
Saturday Apr 28, 2018 at 08:53 GMT


Hi,

could the code also ignore whitespace before and after the statement?

E.g. https://stackoverflow.com/a/216883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant