-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone generated quantities service #172
Comments
Comment by wds15 This sounds like a great thing! If possible, the design should take into account that multiple generated quantities blocks can be defined by the user. As a bonus the user should be able to select which of these blocks get executed. Sorry for jumping ahead...do we have such a ticket already or should I open one and we link it to this issue? |
Comment by bob-carpenter
For the initial implementation, we won't be changing the language to allow multiple generated quantities blocks. Feel free to create an issue with an enhancement to this feature. If you do, you should say how multiple blocks get selected and what the new Stan language would look like. |
Comment by mitzimorris the current implementation for this feature is on branch https://github.com/stan-dev/stan/tree/feature/2432-standalone-gq-service in implementing this, I found a couple of bugs in the generated code. the generated methods regarding the above feature request for multiple generated quantities blocks, this introduces new sources of confusion w/r/t how any set of results were obtained. a much simpler approach would be to keep parallel models with different generated quantities blocks and run them as needed. |
Comment by mitzimorris @bob-carpenter - are these initial comments in the code still valid?
|
Comment by bob-carpenter @mitzimorris: Yes, but they don't have to be addressed right away.
|
Comment by wds15 Thinking about it, I would suggest that we implement different predictive checks with tools we already have. So I imagine, one can get different predictive checks by multiple Stan files which include the right stuff from some common source. Should things work as I expect, then the user can have different generated quantities blocks with this easily. The simplest approach would be to have a Stan model without any generated quantities block and then for each predictive check the user creates a new file which just includes the base Stan model and adds a generated quantities block. I hope this works with what is being put up here, but I guess it should. |
Issue by bob-carpenter
Monday Nov 06, 2017 at 17:26 GMT
Originally opened as stan-dev/stan#2432
Summary:
Something to take in existing draws and produce generated quantities and transformed parameters.
Description:
We need a new object
services::util::generated_quantities_writer
that will let write the header for just the generated quantities.Current Version:
v2.17.0
The text was updated successfully, but these errors were encountered: