Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated output with Node v6.0.0 #106

Closed
mgol opened this issue Apr 18, 2016 · 8 comments
Closed

Truncated output with Node v6.0.0 #106

mgol opened this issue Apr 18, 2016 · 8 comments

Comments

@mgol
Copy link

mgol commented Apr 18, 2016

$ git clone git@github.com:jquery/jquery.git
$ cd jquery
$ git checkout e5ffcb0838c894e26f4ff32dfec162cf624d8d7d
$ david --version
v7.0.1
$ node --version
v6.0.0-rc.2
$ david
devDependencies

┌──────────────────────┬─────────┬────────┐
│ Name                 │ Package │ Latest │
├──────────────────────┼─────────┼────────┤
│ babel-preset-es2015  │ 6.3.13  │ 6.6.0  │
├──────────────────────┼─────────┼────────┤
│ grunt-git-authors    │ 3.1.0   │ 3.1.1  │
├──────────────────────┼─────────┼────────┤
│ load-grunt-tasks     │ 3.4.0   │ %                                                                                              
$ nvm use 5
Now using node v5.10.1 (npm v3.8.3)
$ david
devDependencies

┌──────────────────────┬─────────┬────────┐
│ Name                 │ Package │ Latest │
├──────────────────────┼─────────┼────────┤
│ jsdom                │ 5.6.1   │ 8.4.0  │
├──────────────────────┼─────────┼────────┤
│ babel-preset-es2015  │ 6.3.13  │ 6.6.0  │
├──────────────────────┼─────────┼────────┤
│ strip-json-comments  │ 2.0.0   │ 2.0.1  │
├──────────────────────┼─────────┼────────┤
│ grunt-contrib-watch  │ 0.6.1   │ 1.0.0  │
├──────────────────────┼─────────┼────────┤
│ grunt-newer          │ 1.1.1   │ 1.2.0  │
├──────────────────────┼─────────┼────────┤
│ core-js              │ 2.0.3   │ 2.2.2  │
├──────────────────────┼─────────┼────────┤
│ load-grunt-tasks     │ 3.4.0   │ 3.5.0  │
├──────────────────────┼─────────┼────────┤
│ insight              │ 0.7.0   │ 0.8.1  │
├──────────────────────┼─────────┼────────┤
│ husky                │ 0.11.3  │ 0.11.4 │
├──────────────────────┼─────────┼────────┤
│ qunitjs              │ 1.20.0  │ 1.23.1 │
├──────────────────────┼─────────┼────────┤
│ grunt                │ 0.4.5   │ 1.0.1  │
├──────────────────────┼─────────┼────────┤
│ grunt-git-authors    │ 3.1.0   │ 3.1.1  │
├──────────────────────┼─────────┼────────┤
│ grunt-contrib-uglify │ 0.11.0  │ 1.0.1  │
├──────────────────────┼─────────┼────────┤
│ cross-spawn          │ 2.1.5   │ 2.2.3  │
├──────────────────────┼─────────┼────────┤
│ grunt-cli            │ 0.1.13  │ 1.2.0  │
├──────────────────────┼─────────┼────────┤
│ requirejs            │ 2.1.22  │ 2.2.0  │
└──────────────────────┴─────────┴────────┘

npm install --save-dev jsdom@8.4.0 babel-preset-es2015@6.6.0 strip-json-comments@2.0.1 grunt-contrib-watch@1.0.0 grunt-newer@1.2.0 core-js@2.2.2 load-grunt-tasks@3.5.0 insight@0.8.1 husky@0.11.4 qunitjs@1.23.1 grunt@1.0.1 grunt-git-authors@3.1.1 grunt-contrib-uglify@1.0.1 cross-spawn@2.2.3 grunt-cli@1.2.0 requirejs@2.2.0

@mgol
Copy link
Author

mgol commented Apr 20, 2016

The issue still exists in v6.0.0-rc.3, I've also checked it exists in v6.0.0-rc.0.

@mgol
Copy link
Author

mgol commented Apr 20, 2016

I nailed it down to nodejs/node@c3cec1e.

mgol referenced this issue in nodejs/node Apr 20, 2016
Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@mgol
Copy link
Author

mgol commented Apr 20, 2016

I reported it to Node.js as well in nodejs/node#6297.

@kzc
Copy link

kzc commented Apr 21, 2016

Please take a look at 1 line david fix in nodejs/node#6297 (comment).

@kzc
Copy link

kzc commented Apr 21, 2016

See also: https://github.com/cowboy/node-exit

If process.exit is replaced with exit from the module above, it also appears to correctly drain stdio in david when run with node 6.0.0rc + libuv 1.9.0.

In light of these workarounds I think this node ticket can be closed and no need to revert libuv 1.9.0.

@mgol mgol changed the title Truncated output with Node v6.0.0-rc.2 Truncated output with Node v6.0.0 Apr 26, 2016
@mgol
Copy link
Author

mgol commented Apr 26, 2016

Node 6.0.0 final has been released.

@alanshaw
Copy link
Owner

alanshaw commented May 4, 2016

Thanks for reporting

@kzc
Copy link

kzc commented May 4, 2016

@alanshaw I've changed my opinion on the suitability of node-exit as a replacement for process.exit:

nodejs/node#6410 (comment)

Uglify implemented this approach instead:

https://github.com/mishoo/UglifyJS2/pull/1061/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants