Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification method configurator fails when only one option #101

Closed
alandtse opened this issue Feb 27, 2019 · 2 comments · Fixed by #105
Closed

Verification method configurator fails when only one option #101

alandtse opened this issue Feb 27, 2019 · 2 comments · Fixed by #105
Assignees
Labels
alexapy Issue relates to the API bug Something isn't working

Comments

@alandtse
Copy link
Owner

Based on this post, the verification method should not hard code "email/sms" options as some users will not have both verification options.
image

<form name="claimspicker" method="post" action="verify" class="cvf-widget-form cvf-widget-form-claimspicker a-spacing-none">

<div class="a-row a-spacing-small"><h1>Verification needed</h1></div>
      <!-- Only sms channel is available. -->
<div class="a-row">We will send you a code to ensure the security of your account.</div>
<input type="hidden" name="option" value="sms">
<div class="a-section a-spacing-top-extra-large"><span class="a-button a-button-span12 a-button-primary cvf-widget-btn"><span class="a-button-inner"><input id="continue" tabindex="3" class="a-button-input" type="submit"><span class="a-button-text" aria-hidden="true">Send code</span></span></span></div>
</form>

This is a different screen then the verification options that we properly handle:
image

<form name="claimspicker" method="post" action="verify" class="cvf-widget-form cvf-widget-form-claimspicker a-spacing-none">

<div class="a-row a-spacing-small"><h1>Verification needed</h1></div>
      <!-- There are multiple challenge channels available. -->
<div class="a-row">We will send you a code to verify your identity. This is required when something about your sign-in activity changes, like signing in from a new device or location.</div><p class="a-spacing-none a-spacing-top-extra-large"><label class="a-form-label">Send verification code:</label><div data-a-input-name="option" class="a-radio cvf-widget-input a-spacing-top-base"><label>
<input type="radio" name="option" value="sms" checked><i class="a-icon a-icon-radio"></i><span class="a-label a-radio-label">As a text message - +***********</span></label></div><div data-a-input-name="option" class="a-radio cvf-widget-input a-spacing-top-base"><label>
<input type="radio" name="option" value="email"><i class="a-icon a-icon-radio"></i><span class="a-label a-radio-label">In an email - ************@gmail.com</span></label></div></p>

<div class="a-section a-spacing-top-extra-large"><span class="a-button a-button-span12 a-button-primary cvf-widget-btn"><span class="a-button-inner"><input id="continue" tabindex="3" class="a-button-input" type="submit"><span class="a-button-text" aria-hidden="true">Send code</span></span></span></div>
</form>

The primary difference appears to be the option variable set either by use <input type="radio"> vs <input type="hidden">

@alandtse alandtse added the bug Something isn't working label Feb 27, 2019
@alandtse alandtse self-assigned this Feb 27, 2019
@alandtse alandtse added the alexapy Issue relates to the API label Feb 27, 2019
@alandtse
Copy link
Owner Author

Potential untested fix here.

@alandtse
Copy link
Owner Author

User reports the fix worked. Will stage for deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alexapy Issue relates to the API bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant