-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization suggests too expensive transfers which are not possible with current money #290
Comments
You may need to run |
I thought it might have been that as well. but I deleted my database and then started from scratch. First I ran:
all ran through and then gave me the same result. only things to note are:
and
|
Could you let me know your team ID so I can try to recreate it myself? It's all working as expected as far as I can tell for our team ID. |
Sure thanks for your help. My team_id is 4598470 |
Is it normal to use these seasons |
Yes, we currently fit all the models with data from the current season + the previous 3 seasons, so that's normal. I think it's behaving correctly for me with your ID, or at least it correctly says you are £0.1m short of affording those transfers. Did you install AIrsenal quite recently or was it a while ago? If it was a while ago you could try updating by doing this from the parent AIrsenal directory:
(and then re-run everything) Not sure what else to try next but will think about it tomorrow. |
Hmm I get the same recommended transfers as you, so this must be a bug in the optimisation code somewhere. |
Actually no, I'm wrong - I get the same recommended transfers in, but it suggests transferring out Alonso and Van de Beek, which you can afford with £0.3m spare (according to AIrsenal at least). I'd try reinstalling as described above, if that doesn't work I'm out of ideas. |
I stupidly thought this was a bug and was trying to use information from the year 1920 not for the 2019 to 2020 season!! So I did as you suggested and did the full reinstall which worked - though I am now dubious on the algorithm as it has left me with two players that are injured on the team... but that's just my luck I guess! 😆 |
Yeah, I think it's choosing to remove your more expensive players that have been benched/haven't played much recently, rather than your cheaper injured players. Improving our estimate of how likely someone is to play is definitely something we want to improve, though. |
Thanks, yeah - its a pretty interesting tool in any case. I don't know if it is related, but whenever I try and run_optimization for more than 3 weeks. I get a range of sqlalchemy errors.
and
|
Hmm, there are some nasty sqlalchemy/multiprocessing issues hanging around, e.g. see #81 We don't have fixes, but not using conda or running on a single thread has worked for some people. Or you could try running AIrsenal in a docker container (see the readme). |
after running airsenal_run_pipeline. The suggested optimisation shown below is not possible given the budget. (I am 0.1m short)
Do I need to clean out the database and start again everytime I refresh it?
The text was updated successfully, but these errors were encountered: