Akka.Persistence.Sql.Common: harden SqlJournal and SqlSnapshotStore against initialization failures
#7325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes on this PR are pretty self-explanatory |
Aaronontheweb
added a commit
to Aaronontheweb/Akka.Persistence.Linq2Db
that referenced
this pull request
Aug 23, 2024
4 tasks
Arkatufus
pushed a commit
to akkadotnet/Akka.Persistence.Sql
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I noticed this issue with Akka.Persistence.Sql and will be sending a pull request for that as well, but TL;DR; we had some DNS issues that prevented Akka.Persistence from being able to contact SQL Server initially - this was caused by Kubernetes being slow to resolve a DNS route. The current design basically just kills Akka.Persistence and disallows it from restarting, requiring a restart of the entire process. There's no good reason for this - we can just restart the journal / snapshot store actors instead and give the process a chance of succeeding without a reboot.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):