make AkkaHostedService public + virtual
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-implementation of akkadotnet#299 Made clear in XML-DOC comment, this is a "there be dragons" use case for end-users. We're not going to provide you with much support beyond making this possible. Best of luck.
Aaronontheweb
commented
May 17, 2023
| private readonly AkkaConfigurationBuilder _configurationBuilder; | ||
| private readonly IHostApplicationLifetime? _hostApplicationLifetime; | ||
| private readonly ILogger<AkkaHostedService> _logger; | ||
| protected ActorSystem? ActorSystem; |
There was a problem hiding this comment.
Made all of these accessible in derivative classes.
Aaronontheweb
commented
May 17, 2023
| @@ -11,36 +12,42 @@ namespace Akka.Hosting | |||
| /// <summary> | |||
| /// INTERNAL API | |||
| /// </summary> | |||
| internal sealed class AkkaHostedService : IHostedService | |||
| /// <remarks> | |||
| /// Open for modification in cases where users need fine-grained control over <see cref="Actor.ActorSystem"/> startup and | |||
There was a problem hiding this comment.
Warning to users: there will be tears if you don't study our source code when you try to extend this, and we will not help you with whatever weird DI stuff you're trying to do. Best of luck.
Arkatufus
requested changes
May 17, 2023
| @@ -77,6 +77,34 @@ public static IServiceCollection AddAkka(this IServiceCollection services, strin | |||
|
|
|||
| return services; | |||
| } | |||
|
|
|||
| public static IServiceCollection AddAkka<T>(this IServiceCollection services, string actorSystemName, Action<AkkaConfigurationBuilder, IServiceProvider> builder) where T:AkkaHostedService | |||
There was a problem hiding this comment.
Since the generic code is identical to the non-generic one, we should just call the generic one from inside the non-generic extension method. Saves us the time to have to check that both implementation are the same in the future.
Arkatufus
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298
Changes
Re-implementation of #299 - no abstract base classes, just made the main one public + virtual in order to keep things simple for Akka.Hosting.Maui et
Made clear in XML-DOC comment, this is a "there be dragons" use case for end-users. We're not going to provide you with much support beyond making this possible. Best of luck.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):