Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popupmenu positioned too low #68

Closed
smolck opened this issue Nov 2, 2019 · 1 comment
Closed

Popupmenu positioned too low #68

smolck opened this issue Nov 2, 2019 · 1 comment

Comments

@smolck
Copy link
Contributor

smolck commented Nov 2, 2019

I think the popupmenu should be a little closer to the cursor here, it seems a bit too low:

image

@smolck
Copy link
Contributor Author

smolck commented Nov 3, 2019

I think I've figured out the problem, here's the line that causes it:

y := row*p.ws.font.lineHeight + p.ws.font.lineHeight + p.ws.tabline.widget.Height()

The problem is that p.ws.tabline.widget.Height() is added to the y value of the popupmenu regardless of whether the GoNeovim external tabline is enabled. Thus, when disabled (as I have it) the popupmenu is moved farther down than it should be.

Thus, to fix it we only need to check if the tabline is enabled or not, and if it isn't then don't add the p.ws.tabline.widget.Height() value to y.

@akiyosi akiyosi closed this as completed in f7b5798 Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant