merge dev to master #1020
Merged
merge dev to master #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should discard the possibility of creation of unwanted multiple rows
fixed random whitespaces at the beginning or end fixed alignment issues in centerMode=true and centerMode=false
akiran
reviewed
Feb 25, 2018
| {dots} | ||
| </ul> | ||
| ); | ||
| return React.cloneElement(this.props.appendDots(dots), {className: this.props.dotsClass}); |
There was a problem hiding this comment.
@laveesingh Do we need cloneElement here ?
We can do some thing like this
const AppendDots = this.props.appendDots
return <AppendDots className={this.props.dotsClass} />
There was a problem hiding this comment.
I'll try and replace that.
akiran
reviewed
Feb 25, 2018
| break; | ||
|
|
||
| case 'right': | ||
| case 'up': | ||
| newSlide = this.state.currentSlide - this.getSlideCount(); | ||
| slideCount = this.props.swipeToSlide ? this.checkNavigable(newSlide) : newSlide; | ||
| this.state.currentDirection = 1; | ||
| // this.state.currentDirection = 1; // critical: change this line with setState statement | ||
| this.setState({ currentDirection: 1 }) // unverified fix of above line |
There was a problem hiding this comment.
@laveesingh Can you test this case and remove the unverified comments
akiran
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress
Following are the changes to be mentioned: