Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the service plugin properly usable (#381) #382

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Make the service plugin properly usable (#381) #382

merged 2 commits into from
Apr 21, 2023

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Feb 11, 2023 •
edited
Loading

Fixes #381
Fixes #380

@Vampire
Copy link
Contributor Author

Vampire commented Feb 11, 2023

Btw. something seems to be broken in your test framework.
If I add 8.0-rc-5 to the compat test, it runs but fails with a ClassNotFoundException, while actually using a snapshot build with 8.0-rc-5 works perfectly fine.

@ajoberstar
Copy link
Owner

Thanks for the PR!

@ajoberstar ajoberstar merged commit 2ee722a into ajoberstar:main Apr 21, 2023
@Vampire Vampire deleted the issue-381 branch April 22, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The service plugin is unusable as advertised Property vs. Provider
2 participants
@Vampire @ajoberstar