-
Notifications
You must be signed in to change notification settings - Fork 672
Adds Murex shell support #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds Murex shell support #1111
Conversation
Hi, I've added some minor bugfixes and made it more consistent with the other shells. There's a few more things I'd like to fix before merging:
Do you think you could work on these? |
Sure can! Thanks for reviewing. 😁
On Sep 7, 2025, at 12:55 AM, ajeetdsouza ***@***.***> wrote:
[https://avatars.githubusercontent.com/u/1777663?s=20&v=4]ajeetdsouza left a comment (ajeetdsouza/zoxide#1111)<#1111 (comment)>
Hi, I've added some minor bugfixes and made it more consistent with the other shells. There's a few more things I'd like to fix before merging:
* PWD hooks are possible to implement here. What you need to do is use a global variable called __zoxide_oldpwd, and set up a prompt hook that compares __zoxide_oldpwd with $PWD. If it has changed, set __zoxide_oldpwd=$PWD and call zoxide add $PWD (since the directory has changed).
* z (with no arguments) does not work.
* If you zoxide has no result for your query (e.g. z aoiejfaoiejf), you get a full error trace with a line number. Ideally, we should just return 1 in such a situation.
Do you think you could work on these?
—
Reply to this email directly, view it on GitHub<#1111 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABIO2C63LIADNU7XDC2CXD3RPCFPAVCNFSM6AAAAACF2LCEW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENRTGUYTAOJTGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
- PWD hook - no-argument `z` goes HOME - empty query results no longer throw a stack trace
All right, @ajeetdsouza, thanks for the feedback. I think I've covered your requests. Tests pass here, but I see the ubuntu CI test is still failing. I don't have |
|
Tried zoxide query --score /tmp
z /tmp
# the score should have increased
zoxide query --score /tmp
# when in the same directory, the score should stay the same
zoxide query --score /tmp Also,
|
All right, thanks. I'll keep poking at it. |
It was my understanding (perhaps incorrect) that I'd need to use the zoxide
Have I misunderstood how that's supposed to work? |
The hook is basically designed to increment the score of a directory (using
Hope that clarifies things! Let me know if you have more questions, I'd be happy to help. |
Okay, thanks, that does clarify. Mine is "working"/updating the score because it's overriding default, which means the PWD hook still isn't working right. |
Okay, I think that's got it. Is that Ubuntu CI test significant? It reads like a linter issue, but I don't see anything I recognize as actionable. Let me know if you spot anything else in any case. Happy to keep iterating. |
Murex is niche, but I use it, and I miss zoxide. 😄