Skip sponsor if landed inside of sponsor by skipping with keyboard

[bershanskiy]

Summary

Skip sponsor if landed inside of sponsor by pressing the right arrow key on the keyboard.

Repro steps

1. Open any video with reported sponsors in the middle of it
2. Set playback shortly before sponsor starts
3. Wait for video to reach second within 5 seconds before sponsor start and click "right arrow" on the keyboard to jump into the sponsor.

Desired results

Sponsor is skipped.

Actual results

Sponsor is not skipped.

I'm not sure whether a sponsor should be skipped if the user clicks on the timeline within a sponsor spot, but I think it should be skipped.

[ajayyy]

Hi, this is intended behavior as otherwise the "unskip" button will not work.

Also, sometimes I want to see what I want to miss and hit the arrow to go back, so I wouldn't want that to skip back to the end.

If people think this behavior is unintuitive, I could change it

[NDevTK]

Well this could be a customization option just need to disable ontimeupdate when the key is pressed

[twilight-sparkle-irl]

I had to jump around a ton to figure out why SponsorBlock wasn't doing its job. You could probably just make "unskip" work by setting a flag not to skip that sponsor -- I personally skip around a lot with the keyboard, so having it land inside the sponsor is annoying.

Either that or you could just show the sponsorblock popup when you're inside a sponsor with a "skip" button so that you can both ununskip and click the skip button when you arrow-key into it -- but I'd prefer it'd just work

[ajayyy]

This would be fairly simple to setup now

[SameenAhnaf]

Notice like Skipping within 5 seconds could be shown to confirm the user if landed within any segment. Following options should be added to customize this notice behavior.

1. Always auto-skip
2. Auto-skip within 5 seconds: As mentioned above
3. Manual skip: Landed within Sponsor segment. Skip notice should be shown for 5 seconds
4. Show skip notice until the segment ends

[ajayyy]

Another option:

Skip however much time is required (ie, if there is 2 seconds left until the sponsor, skip the sponsor + 3 seconds)