naming-convention: make parameterProperty configurable

Fixes: #76

Author: ajafff

rules/namingConventionRule.ts

@@ -37,15 +37,16 @@ enum Types {
     parameter = 1 << 2,
     member = 1 << 3,
     property = 1 << 4,
-    method = 1 << 5,
-    type = 1 << 6,
-    class = 1 << 7,
-    interface = 1 << 8,
-    typeAlias = 1 << 9,
-    genericTypeParameter = 1 << 10,
-    enum = 1 << 11,
-    enumMember = 1 << 12,
-    functionVariable = 1 << 13,
+    parameterProperty = 1 << 5,
+    method = 1 << 6,
+    type = 1 << 7,
+    class = 1 << 8,
+    interface = 1 << 9,
+    typeAlias = 1 << 10,
+    genericTypeParameter = 1 << 11,
+    enum = 1 << 12,
+    enumMember = 1 << 13,
+    functionVariable = 1 << 14,
     // tslint:enable:naming-convention
 }
 
@@ -56,7 +57,7 @@ enum TypeSelector {
     functionVariable = variable | Types.functionVariable,
     parameter = variable | Types.parameter,
     property = Types.member | Types.property,
-    parameterProperty = parameter | property,
+    parameterProperty = Types.parameterProperty | parameter | property,
     method = Types.member | Types.method,
     class = Types.type | Types.class,
     interface = Types.type | Types.interface,
@@ -110,6 +111,7 @@ enum Specifity {
     property = 6 << 9,
     method = Specifity.property,
     enumMember = 7 << 9,
+    parameterProperty = enumMember,
     type = 8 << 9,
     class = 9 << 9,
     interface = Specifity.class,

test/rules/naming-convention/default/test.ts.lint

@@ -78,7 +78,6 @@ class TestClass {
                   ~~~ [method name must be in StrictPascalCase]
     constructor(public readonly _foo, protected bar) {}
                                 ~~~~ [parameterProperty name must not have leading underscore]
-                                ~~~~ [parameterProperty name must be in UPPER_CASE]
                                                 ~~~ [parameterProperty name must have leading underscore]
     constructor(private readonly _FOO_Bar) {}
     toJSON() {}

test/rules/naming-convention/parameter-property/test.ts.lint

@@ -0,0 +1,6 @@
+export class Point {
+    constructor(protected x: number, protected y: number, Z: number, public selected: boolean) {}
+                                               ~ [parameterProperty name must be in UPPER_CASE]
+                                                          ~ [parameter name must be in camelCase]
+                                                                            ~~~~~~~~ [parameterProperty name must be in PascalCase]
+}

test/rules/naming-convention/parameter-property/tslint.json

@@ -0,0 +1,17 @@
+{
+  "rulesDirectory": [
+    "../../../../rules"
+  ],
+  "rules": {
+    "naming-convention": [
+      true,
+      {"type": "default", "format": "PascalCase", "leadingUnderscore": "forbid", "trailingUnderscore": "forbid"},
+      {"type": "parameter", "format": "camelCase"},
+      {"type": "variable", "format": "camelCase"},
+      {"type": "property", "format": "camelCase"},
+      {"type": "property", "modifiers": ["public"], "format": "PascalCase"},
+      {"type": "parameterProperty", "modifiers": "protected", "format": "UPPER_CASE"},
+      {"type": "parameterProperty", "filter": "x", "format": "camelCase"}
+    ]
+  }
+}