[NT] Correct the hostname for proxy configurations with port numbers #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavray
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
This PR fixes a bug in the proxy hostname parsing, where we currently accidentally use the wrong field from the parsed
URLobject to refer to the hostname of the proxy. https://developer.mozilla.org/en-US/docs/Web/API/URL — thehostattribute is of the form<host>:<port>if present, whereashostnameis just<host>. How we use the parsed attribute expects just a hostname without a port number.This PR fixes this bug by using the
hostnameattribute of the parsed URL instead of thehostattribute. While I was here, I also added tests for this proxy URL parsing function given there were none before.Checklist: