Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests and codeql in main branch #1495

Closed
wants to merge 1 commit into from
Closed

Run tests and codeql in main branch #1495

wants to merge 1 commit into from

Conversation

kumaranvpl
Copy link
Contributor

@kumaranvpl kumaranvpl commented Jun 3, 2024

Description

We need to run some jobs in main in order to have working badges in our readme file. Else it gets broken.
It is currently broken both in repo readme and in https://faststream.airt.ai/latest/faststream/

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl requested a review from Lancetnik June 3, 2024 07:40
@kumaranvpl kumaranvpl marked this pull request as draft June 3, 2024 07:43
@Lancetnik
Copy link
Member

Can we just remove these badges? We already have test coverage badge - it should be enough, I think

@kumaranvpl
Copy link
Contributor Author

We don't need this. We are going to run CI using cron schedule.

@kumaranvpl kumaranvpl closed this Jun 3, 2024
@kumaranvpl kumaranvpl deleted the fix-badges branch June 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants