Update JavaFX

Author: airsquared

.gitignore

@@ -146,3 +146,5 @@ gradle-app.setting
 # gradle/wrapper/gradle-wrapper.properties
 
 .vscode
+.idea/modules.xml
+.idea/modules

.idea/inspectionProfiles/Project_Default.xml

@@ -21,7 +21,7 @@ import org.gradle.nativeplatform.platform.internal.DefaultNativePlatform
 
 plugins {
     id 'application'
-    id 'com.github.ben-manes.versions' version '0.48.0'
+    id 'com.github.ben-manes.versions' version '0.49.0'
     id 'org.beryx.jlink' version '3.0.0'
     id 'org.openjfx.javafxplugin' version '0.1.0'
 
@@ -62,7 +62,7 @@ dependencies {
 }
 
 javafx {
-    version = '21'
+    version = '21.0.1'
     modules = [ 'javafx.controls', 'javafx.fxml' ]
 }
 

build.gradle

@@ -100,6 +100,7 @@ private static String getUUID() {
         return Prefs.getAnalyticsUUID();
     }
 
+    @SuppressWarnings("ThrowablePrintedToSystemOut")
     private static void sendRequest(String url) {
         try {
             Network.makeVoidRequest(url);

src/main/java/airsquared/blobsaver/app/Analytics.java

@@ -80,29 +80,29 @@ public void initialize() {
                 .orElse(FXCollections.emptyObservableList()));
         versionLabel.textProperty().bind(deviceTypeChoiceBox.valueProperty().map(Devices::getOSNameForType)
                 .orElse("Version"));
-        deviceList.getSelectionModel().selectedItemProperty().addListener((a,b, device) -> loadSavedDevice(device));
+        deviceList.getSelectionModel().selectedItemProperty().addListener((_,_, device) -> loadSavedDevice(device));
         deleteDeviceMenu.textProperty().bind(Bindings.concat("Remove ",
                 Bindings.when(deleteDeviceMenu.disableProperty())
                     .then("Saved Device")
                     .otherwise(Bindings.concat('"', deviceList.getSelectionModel().selectedItemProperty(), '"'))));
         deleteDeviceMenu.disableProperty().bind(deviceList.getSelectionModel().selectedItemProperty().isNull());
         backgroundSettingsMenu.textProperty().bind(Bindings.when(backgroundSettingsButton.selectedProperty())
                 .then("Hide Background Settings").otherwise("Show Background Settings"));
-        backgroundSettingsMenu.setOnAction(__ -> backgroundSettingsButton.fire());
+        backgroundSettingsMenu.setOnAction(_ -> backgroundSettingsButton.fire());
         savedDevicesLabel.textProperty().bind(Bindings.when(backgroundSettingsButton.selectedProperty())
                 .then("Select Devices").otherwise("Saved Devices"));
         backgroundSettingsButton.textProperty().bind(Bindings.when(backgroundSettingsButton.selectedProperty())
                 .then("Back").otherwise("Auto-Save Settings"));
         savedDevicesVBox.effectProperty().bind(Bindings.when(backgroundSettingsButton.selectedProperty())
                 .then(Utils.borderGlow).otherwise((DropShadow) null));
-        allSignedVersionsCheckBox.selectedProperty().addListener(__ -> {
+        allSignedVersionsCheckBox.selectedProperty().addListener(_ -> {
             if (!allSignedVersionsCheckBox.isSelected()) {
                 saveToTSSSaverCheckBox.setSelected(false);
                 saveToSHSHHostCheckBox.setSelected(false);
                 betaCheckBox.setSelected(false);
             }
         });
-        betaCheckBox.selectedProperty().addListener(__ -> betaCheckBox.setEffect(null));
+        betaCheckBox.selectedProperty().addListener(_ -> betaCheckBox.setEffect(null));
         switch (Prefs.getDarkMode()) {
             case DISABLED -> darkDisabled.setSelected(true);
             case SYNC_WITH_OS -> darkSync.setSelected(true);
@@ -357,7 +357,7 @@ public void aboutMenuHandler(Event ignored) {
                 new ButtonType("License"), new ButtonType("Github Repo"), ButtonType.CLOSE);
         alert.initOwner(Main.primaryStage);
         alert.initModality(Modality.WINDOW_MODAL);
-        alert.getDialogPane().getScene().getWindow().focusedProperty().addListener((a, b, focused) -> {
+        alert.getDialogPane().getScene().getWindow().focusedProperty().addListener((_,_, focused) -> {
             if (!focused) alert.close();
         });
         //Activate default behavior for close button
@@ -423,7 +423,7 @@ public void backgroundSettingsHandler() {
         if (backgroundSettingsButton.isSelected()) {
             deviceList.setCellFactory(CheckBoxListCell.forListView(device -> {
                 final SimpleBooleanProperty property = new SimpleBooleanProperty(device.isBackground());
-                property.addListener((a, b, c) -> addBackgroundHandler(device, property));
+                property.addListener((_,_,_) -> addBackgroundHandler(device, property));
                 return property;
             }));
         } else {
@@ -482,7 +482,7 @@ public void chooseTimeToRunHandler() {
     }
 
     public void startBackgroundHandler() {
-        if (Background.isBackgroundEnabled()) { //stops background if already in background
+        if (Background.isBackgroundEnabled()) {
             Background.stopBackground();
             updateBackgroundSettings();
         } else {
@@ -595,12 +595,12 @@ public void readApnonce() {
         Utils.forEachButton(alert2, button -> button.setDisable(true));
 
         var task = new LibimobiledeviceUtil.GetApnonceTask(false);
-        task.setOnSucceeded(__ -> {
+        task.setOnSucceeded(_ -> {
             apnonceField.setText(task.getApnonceResult());
             generatorField.setText(task.getGeneratorResult());
             Utils.forEachButton(alert2, button -> button.setDisable(false));
         });
-        task.setOnFailed(__ -> {
+        task.setOnFailed(_ -> {
             task.getException().printStackTrace();
             if (task.getException() instanceof LibimobiledeviceUtil.LibimobiledeviceException e) {
                 e.showErrorAlert();
@@ -691,14 +691,14 @@ private TSS createTSS(String runningAlertTitle) {
         Utils.forEachButton(runningAlert, button -> button.setDisable(true));
         runningAlert.getDialogPane().getScene().getWindow().setOnCloseRequest(Event::consume);
 
-        tss.setOnScheduled(__ -> runningAlert.show());
-        tss.setOnSucceeded(__ -> {
+        tss.setOnScheduled(_ -> runningAlert.show());
+        tss.setOnSucceeded(_ -> {
             runningAlert.close();
             Alert alert = new Alert(Alert.AlertType.INFORMATION, tss.getValue());
             alert.setHeaderText("Success!");
             alert.showAndWait();
         });
-        tss.setOnFailed(__ -> {
+        tss.setOnFailed(_ -> {
             runningAlert.close();
             tss.getException().printStackTrace();
             parseException(tss.getException());

src/main/java/airsquared/blobsaver/app/Controller.java

@@ -184,7 +184,7 @@ protected Void call() throws LibimobiledeviceException {
     }
 
     /**
-     * @return false if task was cancelled during the Thread.sleep
+     * @return false if task was canceled during the Thread.sleep
      */
     private static boolean sleep(long millis) {
         try {
@@ -354,7 +354,7 @@ private static void throwIfNeeded(int errorCode, ErrorCodeType errorType) throws
 
     public static class LibimobiledeviceException extends Exception {
 
-        public final ErrorCodeType errorType;
+        private final ErrorCodeType errorType;
         public final int errorCode;
         public final boolean reportable;
 

src/main/java/airsquared/blobsaver/app/LibimobiledeviceUtil.java

@@ -91,12 +91,11 @@ static void setJNALibraryPath() {
     }
 
     /**
-     * Apple decided use some old distrusted certificate for the iOS 15.5 IPSW, causing this error:
+     * Apple decided to use some old distrusted certificate for the iOS 15.5 IPSW, causing this error:
      * {@code javax.net.ssl.SSLHandshakeException: TLS Server certificate issued after 2019-12-31 and anchored by a distrusted legacy Symantec root CA: CN=GeoTrust Primary Certification Authority - G2, OU=(c) 2007 GeoTrust Inc. - For authorized use only, O=GeoTrust Inc., C=US }
-     *
+     * <p>
      * This uses reflection/unsafe to make the certificate "trusted" anyway.
-     *s
-     * Writing to private static final fields is from https://stackoverflow.com/a/61150853/5938387
+     * Writing to private static final fields is from <a href="https://stackoverflow.com/a/61150853/5938387">...</a>
      */
     @SuppressWarnings({"Java9ReflectionClassVisibility", "deprecation"})
     static void fixCertificateError() {