gradle: remove deps.toml #45160
Merged
gradle: remove deps.toml #45160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
postamar
force-pushed
the
postamar/remove-deps-toml
branch
from
36c0d09
to
fb59062
Compare
2 tasks
|
/approve-and-merge reason="no-op changes on many connectors" |
|
Check that box |
octavia-approvington
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes the
deps.tomlversion catalog. Responsibility for tracking the correct versions now lies fully with the connectors and with the legacy and bulk CDKs.How
Removed remaining deps.toml references throughout the repo.
Review guide
Because this PR touches a number of connectors in a non-meaningful way, it will be approve-and-merged. The connectors CI can therefore be ignored. The gradle CI step is enough to ensure correctness, as it checks that everything compiles all right.
User Impact
None whatsoever.
Can this PR be safely reverted and rolled back?