Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Add Order Risks + New attributes to Orders schema for Native Shopify connector #3926

Merged
merged 71 commits into from
Jun 8, 2021
Merged

🎉 Add Order Risks + New attributes to Orders schema for Native Shopify connector #3926

merged 71 commits into from
Jun 8, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jun 7, 2021 •
edited
Loading

What

Resolving issue:
#3482 - Additional attributes in shopify schema

How

  1. Added Schema for Order Risks (order_risks.json)
  2. Added stream class OrderRisks() to source.py
  3. Re-defined `orders.json' schema to add all possible attributes from Orders objects
  4. Bumped version of the image

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • CHANGELOG.md
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

bazarnov and others added 30 commits June 1, 2021 19:38
first commit
b315dae
@bazarnov
Delete source copy.py
4b85915 
File doesn't need
IAdded Incremental Refresh + stream_slice for Refunds, Transactions
93a821f
Merge branch 'bazarnov/3581-shopify-cdk-connector' of https://github.…
d2ee9c3 
…com/airbytehq/airbyte into bazarnov/3581-shopify-cdk-connector
small changes to source.py
59cf410
fixed Incremental Refresh
926c914
Fixed acceptence-tests
718eccc
Edited no-refunds-catalog for acceptence-tests
fc44580
changed the state
211307c
Commit for Review
4aa56ab
removed spaces
4c52376
added parameter to orders stream to read all the records by default
658b0ff
added parameter to abandoned_checkouts stream to read all the records…
6fefde0 
… by default
@bazarnov
minor fix
6c6e584
@bazarnov
minor fix
1968848
changed authentication method from basic http > header based auth, re…
04ed53a 
…moved usage of api_key
reformated source.py
5d07a3e
@bazarnov
improved source.py, removed dependencies block from build.gradle
4cf5d7f
@bazarnov
removed unneeded dependencies + formated source.py
1885694
@bazarnov
changed Shopify in source_definitions.yaml from singer-based to cdk v…
9c18348 
…ersion, changed years in the documents
@bazarnov
added source_definition for source-shopify cdk json file
0ad3a27
@bazarnov
Delete airbyte-config/init/bin/main/config/STANDARD_SOURCE_DEFINITION…
f5ebc60 
… directory
@bazarnov
Add files via upload
6cc7644
@bazarnov
added secret credentials for source-shopify
d114bda
@bazarnov
Delete 9da77001-af33-4bcd-be46-6252bf9342b9.json
29fb46f
@bazarnov
Merge branches 'bazarnov/3581-shopify-cdk-connector' and 'bazarnov/35…
4239aa8 
…81-shopify-cdk-connector' of https://github.com/airbytehq/airbyte into bazarnov/3581-shopify-cdk-connector
@bazarnov
re-added source_definition file
f2ff982
@bazarnov
Delete airbyte-config/init/bin/main/config/STANDARD_SOURCE_DEFINITION…
4b89079 
… directory
@bazarnov
re-added source definition
125233a
@bazarnov
Delete airbyte-config/init/bin/main/config/STANDARD_SOURCE_DEFINITION…
f21c71b 
… directory
@bazarnov bazarnov self-assigned this Jun 7, 2021
@bazarnov bazarnov linked an issue Jun 7, 2021 that may be closed by this pull request
Additional attributes in shopify schema #3482
Closed
@bazarnov bazarnov changed the title 🎉 CDK-Source-Shopify/3482-add-order-risks-stream 🎉 Add Order Risks schema for Native Shopify connector Jun 7, 2021
@bazarnov bazarnov changed the base branch from master to bazarnov/3581-shopify-cdk-connector June 7, 2021 15:42
sherifnada
sherifnada suggested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bazarnov I believe the linked issue is not asking for the order risks stream, but for more attributes on the orders stream itself. See the PR contributed by @harshithmullapudi : airbytehq/tap-shopify#4 where it contains the required fields

you can also just go to the orders schema on shopify API and make sure all attributes are reflected

@harshithmullapudi please correct me if I'm wrong

airbyte-integrations/connectors/source-shopify/CHANGELOG.md Show resolved Hide resolved
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 7, 2021

@bazarnov I believe the linked issue is not asking for the order risks stream, but for more attributes on the orders stream itself. See the PR contributed by @harshithmullapudi : airbytehq/tap-shopify#4 where it contains the required fields

you can also just go to the orders schema on shopify API and make sure all attributes are reflected

@harshithmullapudi please correct me if I'm wrong

Confusing part here was to mention "Risks" right down bellow the "Add new attributes to shopify orders schema". I hope now the expectations are met)

@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/916550218
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/916550218

@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 8, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/917803291
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/917803291

Base automatically changed from bazarnov/3581-shopify-cdk-connector to master June 8, 2021 09:46
@bazarnov bazarnov changed the title 🎉 Add Order Risks schema for Native Shopify connector 🎉 Add Order Risks + New attributes to Orders schema for Native Shopify connector Jun 8, 2021
@bazarnov bazarnov merged commit 1686b92 into master Jun 8, 2021
@bazarnov bazarnov deleted the bazarnov/3482-add-risks-to-shopify branch June 8, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshithmullapudi harshithmullapudi harshithmullapudi left review comments

@sherifnada sherifnada sherifnada approved these changes

@midavadim midavadim Awaiting requested review from midavadim

@TymoshokDmytro TymoshokDmytro Awaiting requested review from TymoshokDmytro

@yaroslav-dudar yaroslav-dudar Awaiting requested review from yaroslav-dudar

@davinchia davinchia Awaiting requested review from davinchia

@tuliren tuliren Awaiting requested review from tuliren

Assignees

@bazarnov bazarnov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional attributes in shopify schema
3 participants
@bazarnov @sherifnada @harshithmullapudi