Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to provide custom options in CDC database connectors #5916

Closed
subodh1810 opened this issue Sep 8, 2021 · 4 comments
Closed

Allow user to provide custom options in CDC database connectors #5916

subodh1810 opened this issue Sep 8, 2021 · 4 comments
Labels
area/connectors Connector related issues connectors/source/mysql connectors/source/postgres lang/java team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request

Comments

@subodh1810
Copy link
Contributor

We should allow users to provide custom options such as batch_size in CDC connectors. This has a risk to it that a user might make an incorrect choice so we should try to educate people on how to use it and if they are not sure then stick with the default values.

@yurii-bidiuk
Copy link
Contributor

Hi @subodh1810
Is this ticket relevant now?
If yes, could you please clarify what you mean by custom options?
Should it be some predefined CDC properties where the user can enter only value? Or we should add some input field and users will be able to enter the key and value, something like: max.batch.size=1024;max.queue.size=8192;

@prateekmukhedkar
Copy link
Contributor

Do we see connections setup with incorrect values for Postgres source? Intuitively thinking that users setting up CDC know what they are doing. We should include these in our documentation but do we need any changes in the UI? cc @subodh1810 @misteryeo

@subodh1810
Copy link
Contributor Author

We dont allow users to provide input for these parameters in CDC mode for any connector. But now that I think of it, perhaps we should make the choice for them instead of them having to decide cause chances are pretty high that they wouldnt know how to set the right value.

@misteryeo
Copy link
Contributor

Closing based on latest comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues connectors/source/mysql connectors/source/postgres lang/java team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request
Projects
No open projects
Status: Backlog (unscoped)
Development

No branches or pull requests

7 participants