Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[destination-s3] No more sync_id in filenames #45084

Open
1 task
manuito opened this issue Sep 2, 2024 · 7 comments
Open
1 task

[destination-s3] No more sync_id in filenames #45084

manuito opened this issue Sep 2, 2024 · 7 comments
Labels
area/connectors Connector related issues community connectors/destination/s3 team/destinations Destinations team's backlog type/bug Something isn't working

Comments

@manuito
Copy link

manuito commented Sep 2, 2024

Connector Name

S3 destination

Connector Version

1.0.4

What step the error happened?

During the sync

Relevant information

On airbyte cloud : The sync_id is not anymore present in the generated destination filename for a sync. Everything seems "as usual" but the file is created "without the sync_id", so we have just a file with the run nbr . For example _58 instead of 14235532_58
Our source is shopify
See also https://airbytehq.slack.com/archives/C021JANJ6TY/p1725177438711539

Relevant log output

No response

Contribute

  • Yes, I want to contribute
@manuito
Copy link
Author

manuito commented Sep 2, 2024

Remark : we are using a jsonl format

@SebastienCY
Copy link

Hello,
This happens with a S3 destination configured with S3 Filename pattern = {sync_id}_{part_number}
And very curiously is observed on "random" connections using this destination (not all connections using this destination are impacted), but once a connection is impacted all subsequent sync run are impacted the same.

@SebastienCY
Copy link

Although destination is configured with S3 Filename pattern = {sync_id}_{part_number}, the detination log shows
StreamTransferManager(getMultiPartOutputStreams):329 Initiated multipart upload to airbyte-saas-splio-prod-airbyte-saas-xhw9s4/data_sync/xxxxx/shopify/orders/_1872

@guyarad
Copy link

guyarad commented Sep 3, 2024

@octavia-squidington-iii not sure what does the "community" label mean, but this happens in Airbyte Cloud as well

@edgao
Copy link
Contributor

edgao commented Sep 3, 2024

can I get a link to the cloud connection where this is happening? #44933 seems pretty unlikely to affect the filename, and I don't see an obvious upstream code change that would cause this

I also haven't been able to repro this in my own connection, which is a bit odd

@edgao
Copy link
Contributor

edgao commented Sep 3, 2024

this should be fixed now - there was an unrelated platform update that got rolled out to a subset of users. We rolled back that update, can you try again?

@manuito
Copy link
Author

manuito commented Sep 3, 2024

Thank you for your feedback. We will check starting tomorrow. We have already recreated most of our connections to avoid this condition so not sure if we can confirm it until few days

@marcosmarxm marcosmarxm changed the title [S3 destination] No more sync_id in filenames [destination-s3] No more sync_id in filenames Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues community connectors/destination/s3 team/destinations Destinations team's backlog type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants