Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HttpAvailabilityStrategy read helper methods with Stream.read_full_refresh #30951

Open
2 tasks
girarda opened this issue Sep 29, 2023 · 1 comment
Open
2 tasks
Labels

Comments

@girarda
Copy link
Contributor

girarda commented Sep 29, 2023

What

The HttpAvailabilityStrategy uses helper methods to read the first record of Stream in full refresh.
It should use the new Stream.read_full_refresh method instead

Acceptance criteria

  • HttpAvailabilityStrategy.check_availability uses the stream’s read_full_refresh to check if a record can be read
  • The methods in airbyte-cdk/python/airbyte_cdk/sources/streams/utils/stream_helper.py are deleted
@farheenfathimaa
Copy link

#31384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants